foreman-bootloaders-redhat: Add efinet only on *-efi platforms. #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue introduced in 311d91c, since efinet.mod is only provided for *-efi platforms.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
lzap
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Tested this time:
[root@sat69 ~]# foreman-generate-bootloaders
grub2-mkimage: error: cannot open `/usr/lib/grub/i386-pc//efinet.mod': No such file or directory.
After the patch:
[root@sat69 ~]# foreman-generate-bootloaders
Sorry about breaking this, I did not realize that.
I have to be sorry. I could have sworn I tested it, but apparently I did not test it well enough :-(. At least I realized before a new Foreman release was cut with it. Thanks a lot for merging this :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in 311d91c,
since
efinet.modis only provided for*-efiplatforms.I introduced that bug in #6219 / version
202102211600-1. While the generation works, it fails if generation is done for a non-efi platform, sinceefinet.moddoes not exist there.