Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add katello-host-tools for debian/ubuntu #6958

Open
wants to merge 2 commits into
base: deb/develop
Choose a base branch
from

Conversation

sbernhard
Copy link

No description provided.

@sbernhard
Copy link
Author

I think, I will need help to finish this successfully.

@pcreech
Copy link
Member

pcreech commented Oct 18, 2021

[test deb]

1 similar comment
@pcreech
Copy link
Member

pcreech commented Nov 18, 2021

[test deb]

@sbernhard
Copy link
Author

I guess, this needs at least theforeman/jenkins-jobs#152
Additonally, katello-host-tools need to be pushed to pip. What are your thoughts @jturel

@jturel
Copy link

jturel commented Nov 22, 2021

Additonally, katello-host-tools need to be pushed to pip. What are your thoughts @jturel

That seems like more work. Why do we need to do that?

@evgeni
Copy link
Member

evgeni commented Nov 22, 2021

We don't require it, but it makes things easier ;)
As we fetch gems from rubygems, we fetch python stuff from pypi.

@sbernhard
Copy link
Author

Somehow the source needs to be provided. Or should the source just be made avilable via git-annex? Currently I dont know how this can be done in deb build env.

@jturel
Copy link

jturel commented Nov 22, 2021

We don't require it, but it makes things easier ;) As we fetch gems from rubygems, we fetch python stuff from pypi.

Do we have a "foreman" org over there or anything, or automation to do the pushing? Trying to avoid having to do that by hand - can you blame me?

@evgeni
Copy link
Member

evgeni commented Nov 22, 2021

We do have a bot that pushes things, yeah. Things can be arranged ;)

@ekohl
Copy link
Member

ekohl commented Dec 9, 2021

Take https://github.com/theforeman/obal/blob/master/.github/workflows/release.yml for example. If you push a tag, automation will push it to PyPI.

@evgeni
Copy link
Member

evgeni commented Jan 20, 2022

[test deb]

@evgeni
Copy link
Member

evgeni commented Jan 20, 2022

well, it failed, so at least it did try to build something 🙈

@evgeni
Copy link
Member

evgeni commented Jan 20, 2022

[test deb]

@evgeni
Copy link
Member

evgeni commented Jan 20, 2022

now the failure is legit, there is no katello-host-tools on PyPI right now.

@sbernhard
Copy link
Author

now the failure is legit, there is no katello-host-tools on PyPI right now.

@jturel How do we want to handle this? The "easiest" solution is, to put katello-host-tools on PyPi. Otherwise we need to find another solution to provide the source.

@evgeni
Copy link
Member

evgeni commented Jan 20, 2022

the other alternative is we implement a kind of "source_url" entry in the build_vars, and make that point at https://github.com/Katello/katello-host-tools/archive/refs/tags/$VERSION.tar.gz or similar.

But I would prefer PyPI as it has a rather standardized interface (which we already implement)

@jturel
Copy link

jturel commented Jan 21, 2022

now the failure is legit, there is no katello-host-tools on PyPI right now.

@jturel How do we want to handle this? The "easiest" solution is, to put katello-host-tools on PyPi. Otherwise we need to find another solution to provide the source.

I guess that's OK? I don't have any experience with putting a project there. If one of us does it first, are we able to grant access to others to do so as well? ie I don't want to be the only person who can perform a release to pypi :)

@ekohl
Copy link
Member

ekohl commented Jan 21, 2022

You can use https://github.com/theforeman/obal/blob/master/.github/workflows/release.yml. It may be better if a GH admin sets the secret for you. I'm not a Katello GH admin so I can't do that. @evgeni?

@evgeni
Copy link
Member

evgeni commented Jan 21, 2022

I am not an admin either.

@jturel
Copy link

jturel commented Jan 21, 2022

I am but, well, I don't have the password!

@ekohl
Copy link
Member

ekohl commented Jan 24, 2022

So I added an API token to the project and opened Katello/katello-host-tools#123. While looking at the code I think bin/ won't be part of the resulting tarball. See obal for an example of how to do this. It maps a command to be generated to a function in the code (in this case obal.main).

@sbernhard could you pick up this effort?

Edit: or if you don't need bin/* at all, there's no work to be done.

@sbernhard
Copy link
Author

dit: or if you don't need bin/* at all, there's no work to be done.

Well, the files in /bin/* are required and the zypper / apt / yum plugins, too. Actually, I don't know the purpose of setup.py regarding creating a simple tarball.

@ekohl
Copy link
Member

ekohl commented Jan 25, 2022

Well, the files in /bin/* are required and the zypper / apt / yum plugins, too. Actually, I don't know the purpose of setup.py regarding creating a simple tarball.

Try python setup.py sdist. You'll end up with a tarball that's uploaded to PyPI. The old way is listing those bin/* files in scriptsinsetup.py`. The modern way is to ship the code inside the package itself and using the console entry points. Then an appropriate wrapper is generated during installation.

@ekohl
Copy link
Member

ekohl commented Feb 19, 2022

Since there has been no progress on this, I took a stab at this and opened Katello/katello-host-tools#125. That will likely also have packaging consequences, both RPM and deb side.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That has been released and 4.0.1 should be available on PyPI. Please update the PR to reflect that.

@ekohl
Copy link
Member

ekohl commented Feb 23, 2022

I took a look at the RPM and I realized we don't ship all the additional files (etc, extra) in the tarball on PyPI. That's probably something to address.

@sbernhard
Copy link
Author

Need Katello/katello-host-tools#130 before we can continue.

@sbernhard
Copy link
Author

[test deb]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants