Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #8996 - use Ruby 1.9 for hammer on precise #713

Merged
merged 1 commit into from
Aug 4, 2015
Merged

fixes #8996 - use Ruby 1.9 for hammer on precise #713

merged 1 commit into from
Aug 4, 2015

Conversation

mmoll
Copy link

@mmoll mmoll commented Jul 29, 2015

yet untested.

@domcleal
Copy link
Contributor

Interesting, I'll try and give it a go soon. I was wondering if we should rely on the Brightbox version too, but hopefully the p0 in 12.04 will be enough.

@domcleal
Copy link
Contributor

domcleal commented Aug 3, 2015

A quick test of upgrading installed the right locale package, but the shebang line in /usr/bin/hammer needs changing to ruby1.9.1 after which point a host list worked fine.

(This was on a Brightbox-enabled install, so it was using their latest patch release, not the default p0.)

@mmoll
Copy link
Author

mmoll commented Aug 3, 2015

This should be handled by the XS-Ruby-Versions line, need to check this again...

@domcleal
Copy link
Contributor

domcleal commented Aug 3, 2015

Hm okay, it was just /usr/bin/env ruby.

@mmoll
Copy link
Author

mmoll commented Aug 3, 2015

I see the problem now: https://wiki.debian.org/Teams/Ruby/Packaging#Handling_of_shebangs requires /usr/bin/ruby, while hammer is using /usr/bin/env ruby, I'll just replace this after unpacking and see what's happening.

@mmoll
Copy link
Author

mmoll commented Aug 3, 2015

Should all be fine now. By also dropping the dependency onto the rubygems package, it even works without any ruby1.8 components.

@domcleal domcleal merged commit b8fe71a into theforeman:deb/develop Aug 4, 2015
@domcleal
Copy link
Contributor

domcleal commented Aug 4, 2015

Merged, thanks very much @mmoll! Building now.

@mmoll mmoll deleted the deb/precise_19 branch August 4, 2015 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants