Add source_location in build_vars.sh for nightly packages #7211
Conversation
|
I'd drop the quotes, they shouldn't be needed in either format (shell, key=value). Are those files to be removed during beaching, or will they be ignored? |
During beaching, any files present will be soaked in water and therefore have no affect on the build. There is a nightly wrapper check in the job -- https://github.com/theforeman/jenkins-jobs/pull/128/files#diff-c12500cef361f017ede0862bcabf9b799c8e4b9287be181a1d74203617208968R219 |
ehelms
force-pushed
the
add-source-location-build-vars
branch
from
d95d852
to
5f29cf0
Compare
|
🏖️ okay, yeah, I can see that, and for the non-nightly packages this is also loaded, but then we don't care about |
|
@ekohl want to give your thoughts? @evgeni are you good with the approach? The CI PR theforeman/jenkins-jobs#128 is up to date based on this PR. |
|
I think this is ok. The only consideration I have is with #7202 and merge conflicts. There's probably already a few so I'd prefer to avoid rebasing all the time. |
ehelms
force-pushed
the
add-source-location-build-vars
branch
from
5f29cf0
to
4bd427e
Compare
|
Updated and rebased on #7202 |
No description provided.