foreman-puppet: don't run db:migrate in postinst #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Nov 4, 2021
| else | ||
| /usr/sbin/foreman-rake db:migrate >> $LOGFILE 2>&1 || true | ||
| /usr/sbin/foreman-rake db:seed >> $LOGFILE 2>&1 || true | ||
| /usr/sbin/foreman-rake apipie:cache:index >> $LOGFILE 2>&1 || true |
There was a problem hiding this comment.
huh, I guess this should still happen?
There was a problem hiding this comment.
I do think we should keep, I wondered if this should be the plugin version of it like RPM?
There was a problem hiding this comment.
yeah (and no), the line you're linking to is the compile step, not the index step
evgeni
force-pushed
the
drop-migrate-puppet
branch
from
bddcb65
to
3c66224
Compare
|
yepp, this is def needed to unbreak upgrades |
ehelms
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.