Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubygem-foreman_discovery to 19.0.1 (CP 3.1) #7338

Merged
merged 1 commit into from Nov 25, 2021

Conversation

lzap
Copy link
Member

@lzap lzap commented Nov 25, 2021

(cherry picked from commit e4801eb)

DO NOT MERGE until I test that on RC1.

@theforeman-bot theforeman-bot added RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Nov 25, 2021
@evgeni
Copy link
Member

evgeni commented Nov 25, 2021

NameError: uninitialized constant DiscoveryTaxonomyExtensions::EnsureNotUsedBy

Which I think answers the question @tbrisker and I had, whether the change is backward compatible :(

@lzap lzap changed the title Update rubygem-foreman_discovery to 19.0.0 (CP 3.1) Update rubygem-foreman_discovery to 19.0.1 (CP 3.1) Nov 25, 2021
@lzap
Copy link
Member Author

lzap commented Nov 25, 2021

Allright, reversed that commit in 19.0.1, updated.

@lzap
Copy link
Member Author

lzap commented Nov 25, 2021

Let me finish testing of 19.0.1 with 3.1, then I will bump nightly to 20.0 so versioning is not confusing.

@lzap
Copy link
Member Author

lzap commented Nov 25, 2021

So it works on 3.1 RC1. Here is the deb counterpart:

#7340

RTM TY

@evgeni evgeni merged commit c110660 into theforeman:rpm/3.1 Nov 25, 2021
@lzap lzap deleted the rpm/3.1-discovery1900 branch November 25, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing RPM Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
3 participants