Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't install thor, fetching it is sufficient #7662

Closed
wants to merge 1 commit into from

Conversation

pcreech
Copy link
Member

@pcreech pcreech commented Mar 3, 2022

(cherry picked from commit 6e43b17)

@theforeman-bot theforeman-bot added Needs testing Not yet reviewed DEB Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Mar 3, 2022
@pcreech
Copy link
Member Author

pcreech commented Mar 3, 2022

@evgeni since this is your commit, mind double checking me real quick?

@evgeni
Copy link
Member

evgeni commented Mar 3, 2022

This is exactly the opposite of what I've expected. Will check in detail tomorrow

@evgeni
Copy link
Member

evgeni commented Mar 3, 2022

Like this: 62560ba

@upadhyeammit
Copy link

@pcreech request to do changes mentioned by @evgeni , so we can unblock the 3.0.2 release of Foreman.

@pcreech
Copy link
Member Author

pcreech commented Mar 7, 2022

@evgeni updated

@evgeni
Copy link
Member

evgeni commented Mar 7, 2022

can you add a changelog entry please, otherwise builds won't get triggered.

@evgeni
Copy link
Member

evgeni commented Mar 7, 2022

and I think debian/bionic/foreman/rules needs a similar change, which you omitted?

(cherry picked from commit 62560ba)
@pcreech
Copy link
Member Author

pcreech commented Mar 8, 2022

I retried the pick. For some reason, looks like bionic didn't have a "rules" file change come along with it. I updated the thor line along the same basis as the rest of the rules changes.

Updated changelogs this time around as well.

@evgeni
Copy link
Member

evgeni commented Mar 8, 2022

probably because bionic is not supported on newer releases

@pcreech
Copy link
Member Author

pcreech commented Mar 8, 2022

@evgeni any insight as to why the build failed with Could not find thor-1.1.0.gem for installation

@evgeni
Copy link
Member

evgeni commented Mar 8, 2022

let's try to get all changes from newer branches: #7676

@pcreech
Copy link
Member Author

pcreech commented Mar 9, 2022

@evgeni I'm considering this obsoleted by your PRs and closing.

@pcreech pcreech closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEB Needs testing Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
4 participants