New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package smart_proxy_dns_powerdns #791

Merged
merged 2 commits into from Sep 2, 2015

Conversation

Projects
None yet
4 participants
@ekohl
Copy link
Member

ekohl commented Aug 30, 2015

No description provided.

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Aug 30, 2015

I should note that https://packages.debian.org/jessie/ruby-mysql2 is only available on Jessie now.

@@ -0,0 +1,2 @@
version=3

This comment has been minimized.

@mmoll

mmoll Aug 30, 2015

Member

this file can get deleted

@ekohl ekohl force-pushed the ekohl:deb/smart_proxy_dns_powerdns branch from 9dffdc6 to 7be0e10 Aug 30, 2015

@@ -0,0 +1,5 @@
ruby-smart-proxy-dns-powerdns (0.1.0-0) stable; urgency=low

This comment has been minimized.

@mmoll

mmoll Aug 30, 2015

Member

the revision should be -1

@mmoll

This comment has been minimized.

Copy link
Member

mmoll commented Aug 30, 2015

👍 after changing the revision

@ekohl ekohl force-pushed the ekohl:deb/smart_proxy_dns_powerdns branch from 7be0e10 to 7677151 Aug 30, 2015

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Aug 30, 2015

Updated and also copied ruby-mysql2 from wheezy backports.

@ekohl ekohl force-pushed the ekohl:deb/smart_proxy_dns_powerdns branch 2 times, most recently from 79f7940 to 606ac54 Aug 30, 2015

@mmoll

This comment has been minimized.

Copy link
Member

mmoll commented Aug 30, 2015

The copied ruby-mysql2 could have some files deleted as we don't run the tests after building the gem normally, but as it's an 1:1 copy I'm fine with it. 👍

Depends: ${shlibs:Depends}, ${misc:Depends}, ruby | ruby-interpreter, foreman-proxy (>= 1.1.10~rc1), ruby-mysql2
Recommends: pdns-server
Description: PowerDNS DNS provider plugin for Foreman's smart proxy
PowerDNS DNS provider plugin for Foreman's smart proxy

This comment has been minimized.

@domcleal

domcleal Sep 2, 2015

Contributor

Duplicate line?

This comment has been minimized.

@ekohl

ekohl Sep 2, 2015

Member

This was generated by gem2deb and the salt plugin has the same thing, so I left it. @mmoll?

This comment has been minimized.

@mmoll

mmoll Sep 2, 2015

Member

That's OK, the further line(s) with spaces are the extended description and might actually even be required.

Source: https://github.com/theforeman/smart_proxy_dns_powerdns

Files: *
Copyright: 2015 Red Hat Inc. <foreman-dev@googlegroups.com>

This comment has been minimized.

@domcleal

domcleal Sep 2, 2015

Contributor

Perhaps just yourself, or Foreman developers? Ditto below.

This comment has been minimized.

@ekohl

ekohl Sep 2, 2015

Member

Tbh I didn't really think of a licence and don't know what the policy is. I'm fine with just my name there but I don't care that much as long as the plugin is used and open :)

@domcleal domcleal removed the Needs testing label Sep 2, 2015

@ekohl ekohl force-pushed the ekohl:deb/smart_proxy_dns_powerdns branch from 606ac54 to 387d6fd Sep 2, 2015

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Sep 2, 2015

Verified it works on Debian Wheezy and Jessie (using debstaging.theforeman.org). Updated the copyright by just putting my name there.

@ekohl

This comment has been minimized.

Copy link
Member

ekohl commented Sep 2, 2015

Failures appear to be because it tries to build ruby-mysql2 for jessie and trusty but they don't need it.

@ekohl ekohl force-pushed the ekohl:deb/smart_proxy_dns_powerdns branch from 387d6fd to b24ad70 Sep 2, 2015

ekohl added some commits Aug 30, 2015

Add ruby-mysql2 dependency for smart_proxy_dns_powerdns
This is copied unmodified from Debian wheezy-backports

@mmoll mmoll merged commit b24ad70 into theforeman:deb/develop Sep 2, 2015

1 check was pending

default Running build
Details
@mmoll

This comment has been minimized.

Copy link
Member

mmoll commented Sep 2, 2015

merged, bedankt @ekohl!
building now

@ekohl ekohl deleted the ekohl:deb/smart_proxy_dns_powerdns branch Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment