Skip to content

Package smart_proxy_dns_powerdns#791

Merged
mmoll merged 2 commits intotheforeman:deb/developfrom
ekohl:deb/smart_proxy_dns_powerdns
Sep 2, 2015
Merged

Package smart_proxy_dns_powerdns#791
mmoll merged 2 commits intotheforeman:deb/developfrom
ekohl:deb/smart_proxy_dns_powerdns

Conversation

@ekohl
Copy link
Copy Markdown
Member

@ekohl ekohl commented Aug 30, 2015

No description provided.

@ekohl
Copy link
Copy Markdown
Member Author

ekohl commented Aug 30, 2015

I should note that https://packages.debian.org/jessie/ruby-mysql2 is only available on Jessie now.

Comment thread plugins/smart_proxy_dns_powerdns/watch Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file can get deleted

@ekohl ekohl force-pushed the deb/smart_proxy_dns_powerdns branch from 9dffdc6 to 7be0e10 Compare August 30, 2015 21:41
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the revision should be -1

@mmoll
Copy link
Copy Markdown

mmoll commented Aug 30, 2015

👍 after changing the revision

@ekohl ekohl force-pushed the deb/smart_proxy_dns_powerdns branch from 7be0e10 to 7677151 Compare August 30, 2015 22:03
@ekohl
Copy link
Copy Markdown
Member Author

ekohl commented Aug 30, 2015

Updated and also copied ruby-mysql2 from wheezy backports.

@ekohl ekohl force-pushed the deb/smart_proxy_dns_powerdns branch 2 times, most recently from 79f7940 to 606ac54 Compare August 30, 2015 22:20
@mmoll
Copy link
Copy Markdown

mmoll commented Aug 30, 2015

The copied ruby-mysql2 could have some files deleted as we don't run the tests after building the gem normally, but as it's an 1:1 copy I'm fine with it. 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was generated by gem2deb and the salt plugin has the same thing, so I left it. @mmoll?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK, the further line(s) with spaces are the extended description and might actually even be required.

@ekohl ekohl force-pushed the deb/smart_proxy_dns_powerdns branch from 606ac54 to 387d6fd Compare September 2, 2015 21:01
@ekohl
Copy link
Copy Markdown
Member Author

ekohl commented Sep 2, 2015

Verified it works on Debian Wheezy and Jessie (using debstaging.theforeman.org). Updated the copyright by just putting my name there.

@ekohl
Copy link
Copy Markdown
Member Author

ekohl commented Sep 2, 2015

Failures appear to be because it tries to build ruby-mysql2 for jessie and trusty but they don't need it.

@ekohl ekohl force-pushed the deb/smart_proxy_dns_powerdns branch from 387d6fd to b24ad70 Compare September 2, 2015 22:30
@mmoll mmoll merged commit b24ad70 into theforeman:deb/develop Sep 2, 2015
@mmoll
Copy link
Copy Markdown

mmoll commented Sep 2, 2015

merged, bedankt @ekohl!
building now

@ekohl ekohl deleted the deb/smart_proxy_dns_powerdns branch September 3, 2015 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants