use foreman postinst library for deface too #8252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Jul 19, 2022
| @@ -8,6 +8,6 @@ Homepage: https://github.com/DefaceCommunity/deface | |||
|
|
|||
| Package: ruby-foreman-deface | |||
| Architecture: all | |||
| Depends: ${misc:Depends}, bundler, foreman | |||
| Depends: ${misc:Depends}, foreman (>= 3.1.0~) | |||
There was a problem hiding this comment.
3.1 is the version introducing this helper and foreman already depends on bundler if needed.
while deface is not a plugin as such, it is handled as one when it comes to installation/post installation and so we can just re-use our plugin postinstall library for it too.
ekohl
approved these changes
Jul 19, 2022
One day we will have a way to update deps automagically. Today is not that day ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while deface is not a plugin as such, it is handled as one when it comes
to installation/post installation and so we can just re-use our plugin
postinstall library for it too.