Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35852 - Add isoinfo dependency #8834

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from

Conversation

bastian-src
Copy link

Refer to Smart Proxy PR.

Adds dependency isoinfo which is used to extract images.

@bastian-src bastian-src changed the title Add isoinfo dependency for image extraction Fixes #35852 - Add isoinfo dependency Dec 12, 2022
@evgeni
Copy link
Member

evgeni commented Dec 12, 2022

Where is that package from? I don't see it in CentOS?

Edit: ah, it's in the genisoimage package, so you need to depend on that, or use the full path /usr/bin/isoinfo so that dnf knows it needs to resolve a path not a package

@bastian-src
Copy link
Author

ah thanks! I thought it would be only for debian genisoimage. Gonna change it accordingly!

@bastian-src
Copy link
Author

@evgeni this feature adds a folder /var/lib/foreman-proxy/tftp/system_images to store OS iso images.
Do you think it's okay to implement it with these static paths or is it better to create a variable for {_sharedstatedir}/%{name}/tftp/system_images? (I'll adapt the deb PR accordingly)

* isoinfo is provided by genisoimage package
* Add /var/lib/foreman-proxy/tftp/system_images folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants