New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubygem-kubeclient and fog-kubevirt #8843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoetz
force-pushed
the
rpm/kubevirt-1.3.7
branch
from
December 15, 2022 08:50
f0c8d37
to
7bc1351
Compare
dgoetz
force-pushed
the
rpm/kubevirt-1.3.7
branch
from
December 15, 2022 08:56
7bc1351
to
3128169
Compare
ekohl
reviewed
Dec 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some minor comments.
packages/plugins/rubygem-recursive-open-struct/rubygem-recursive-open-struct.spec
Outdated
Show resolved
Hide resolved
packages/plugins/rubygem-recursive-open-struct/rubygem-recursive-open-struct.spec
Outdated
Show resolved
Hide resolved
dgoetz
force-pushed
the
rpm/kubevirt-1.3.7
branch
from
December 19, 2022 11:43
3128169
to
c06b8fa
Compare
Fixed your comments, thanks. Now waiting for it to get green. |
ekohl
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this, but looks good.
$ koji -p katello add-pkg --owner kojiadm foreman-plugins-nightly-el8 rubygem-jsonpath
Adding 1 packages to tag foreman-plugins-nightly-el8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for relaxing the dependency on http gem and to fix a vulnerability in kubeclient.