New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies for Katello 4.10 #9870
Conversation
@@ -2,7 +2,7 @@ | |||
%global gem_name pulp_ansible_client | |||
|
|||
Name: rubygem-%{gem_name} | |||
Version: 0.18.0 | |||
Version: 0.18.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a cherry pick from develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, looks like 0.18.1 is not already merged to rpm/develop. there is a pr open for 0.18.2, but since 0.18.1 is current in pulp-packaging rpm/3.28, i'm confident in keeping pulp_ansible_client as is. pulp_deb_client did have another PR opened, so I'm removing that change from this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we then at least first open a manual PR to nightly so 4.10 won't be newer than nightly? Because it sounds like we shouldn't update to 0.18.2 yet, but I' also avoid downgrades in nightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr to nightly opened by github actions for 0.18.2 has been merged. #9844
@@ -2,7 +2,7 @@ | |||
%global gem_name pulp_ansible_client | |||
|
|||
Name: rubygem-%{gem_name} | |||
Version: 0.18.0 | |||
Version: 0.18.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we then at least first open a manual PR to nightly so 4.10 won't be newer than nightly? Because it sounds like we shouldn't update to 0.18.2 yet, but I' also avoid downgrades in nightly.
@@ -2,7 +2,7 @@ | |||
%global gem_name pulpcore_client | |||
|
|||
Name: rubygem-%{gem_name} | |||
Version: 3.28.11 | |||
Version: 3.28.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: nightly shouldn't older than a stable branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#9731 has been merged, putting nightly at 3.28.17
I'd appreciate it if the nightly commits were picked with |
So, it's not explicitly 1-1. The PRs against nightly go from pulp_ansible 0.18.0 to 0.18.2, whereas this pr updates pulp_ansible_client to 0.18.1 for this branch. Same with pulpcore_client, it goes from 3.28.11 to 3.28.17 for nightly, where this PR updates it to 3.28.16. At this time, for the 3.8 branch, the corresponding versions in this PR are 1-1 with what is published for 3.28 to release alongside katello 4.10 |
I just realized this also included a Hammer update. Perhaps we should split that off and merge it while we deal with Pulp in a separate way. |
So, uh, what is the state here? |
We had some offline discussions about this. I recall we settled on it not being needed for GA. The differences are minimal. Probably still good to update the plugins themselves in pulpcore-packaging and then the bindings. But then we can cherry pick from nightly |
theforeman/jenkins-jobs#436 was merged, dropping 4.10, so closing here. |
No description provided.