Fixes #21378 - Add CSV export on tasks index

app/controllers/foreman_tasks/tasks_controller.rb

@@ -1,6 +1,7 @@
 module ForemanTasks
   class TasksController < ::ApplicationController
     include Foreman::Controller::AutoCompleteSearch
+    include Foreman::Controller::CsvResponder
 
     before_action :restrict_dangerous_actions, :only => [:unlock, :force_unlock]
 
@@ -11,6 +12,14 @@ def show
     def index
       params[:order] ||= 'started_at DESC'
       @tasks = filter(resource_base)
+      respond_to do |format|
+        format.html do
+          render :index
+        end
+        format.csv do
+          csv_response(@tasks, [:to_label, :state, :result, 'started_at.in_time_zone', 'ended_at.in_time_zone', :username], ['Action', 'State', 'Result', 'Started At', 'Ended At', 'User'])
+        end
+      end
     end
 
     def sub_tasks

app/helpers/foreman_tasks/tasks_helper.rb

@@ -1,17 +1,7 @@
 module ForemanTasks
   module TasksHelper
-    def format_task_input(task, include_action = false)
-      return '-' unless task
-      parts = []
-      parts << task.get_humanized(:name) if include_action
-      parts << Array(task.get_humanized(:input)).map do |part|
-        if part.is_a? Array
-          part[1][:text]
-        else
-          part.to_s
-        end
-      end.join('; ')
-      parts.join(' ')
+    def format_task_input(task)
+      task ? task.to_label : '-'
     end
 
     def format_recurring_logic_limit(thing)

app/models/foreman_tasks/task.rb

@@ -202,6 +202,19 @@ def sub_tasks_counts
       result.symbolize_keys
     end
 
+    def to_label
+      parts = []
+      parts << get_humanized(:name)
+      parts << Array(get_humanized(:input)).map do |part|
+        if part.is_a? Array
+          part[1][:text]
+        else
+          part.to_s
+        end
+      end.join('; ')
+      parts.join(' ')
+    end
+
     protected
 
     def generate_id

app/views/foreman_tasks/recurring_logics/index.html.erb

@@ -18,7 +18,7 @@
     <tr>
       <td><%= link_to(recurring_logic.cron_line, foreman_tasks_recurring_logic_path(recurring_logic)) %></td>
       <td><%= link_to(recurring_logic.tasks.count, foreman_tasks_tasks_url(:search => "task_group.id = #{recurring_logic.task_group.id}")) %></td>
-      <td><%= format_task_input(recurring_logic.tasks.first, true) %></td>
+      <td><%= format_task_input(recurring_logic.tasks.first) %></td>
       <td><%= recurring_logic.tasks.order(:started_at).where('started_at IS NOT NULL').last.try(:started_at) || "-" %></td>
       <td><%= recurring_logic_next_occurrence recurring_logic %></td>
       <td><%= recurring_logic.iteration %></td>

app/views/foreman_tasks/task_groups/recurring_logic_task_groups/_recurring_logic_task_group.html.erb

@@ -10,7 +10,7 @@
   </tr>
   <tr>
     <th><%= N_("Action") %></th>
-    <td><%= format_task_input(recurring_logic.tasks.last, true) %></td>
+    <td><%= format_task_input(recurring_logic.tasks.last) %></td>
   </tr>
   <tr>
     <th><%= N_("Last occurrence") %></th>

app/views/foreman_tasks/tasks/_details.html.erb

@@ -89,8 +89,7 @@
   <div class="col-md-6">
     <div>
       <span class="param-name list-group-item-heading"><%= _("Name") %>:</span>
-      <% task_label = format_task_input(@task, true) %>
-      <span class="param-value" data-original-title="<%= task_label %>" rel="twipsy"> <%= truncate(task_label, :length => 50) %></span>
+      <span class="param-value" data-original-title="<%= @task.to_label %>" rel="twipsy"> <%= truncate(@task.to_label, :length => 50) %></span>
     </div>
     <div>
       <span class="param-name list-group-item-heading"><%= _("Result") %>:</span>

app/views/foreman_tasks/tasks/index.html.erb

@@ -1,5 +1,5 @@
 <% title _("Tasks") %>
-<% title_actions SETTINGS[:version].short <= '1.13' ? help_path : help_button %>
+<% title_actions csv_link, help_button %>
 <% stylesheet 'foreman_tasks/tasks' %>
 
 <script>
@@ -27,7 +27,7 @@ $(document).on('click', ".table-two-pane td.two-pane-link", function(e) {
   <% for task in @tasks %>
     <tr>
       <td class="task-id two-pane-link ellipsis">
-        <%= link_to_if_authorized(format_task_input(task, true),
+        <%= link_to_if_authorized(task.to_label,
         hash_for_foreman_tasks_task_path(:id => task)) %>
       </td>
       <td class="ellipsis"><%= task.state %></td>

test/helpers/foreman_tasks/tasks_helper_test.rb

@@ -11,12 +11,11 @@ class TasksHelperTest < ActionView::TestCase
       end
 
       it 'formats the task input properly' do
-        format_task_input(@task).must_equal("user 'Anonymous Admin'")
-        format_task_input(@task, true).must_equal("Create user 'Anonymous Admin'")
+        format_task_input(@task).must_equal("Create user 'Anonymous Admin'")
       end
 
       it 'displays the dash if task is nil' do
-        format_task_input(nil, true).must_equal('-')
+        format_task_input(nil).must_equal('-')
       end
     end
 
@@ -36,8 +35,7 @@ class TasksHelperTest < ActionView::TestCase
 
       it 'formats the task input properly' do
         response = "product 'product-2'; organization 'test-0'"
-        format_task_input(@task).must_equal(response)
-        format_task_input(@task, true).must_equal("Create #{response}")
+        format_task_input(@task).must_equal("Create #{response}")
       end
     end
   end