Fixes #20230 - Add time ended to error tasks widget #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Jul 10, 2017
| <th class="col-md-5"><%= _("Name") %></th> | ||
| <th class="col-md-2"><%= _("State") %></th> | ||
| <th class="col-md-2"><%= _("Result") %></th> | ||
| <th class="col-md-3"><%= _("Ended at") %></th> |
There was a problem hiding this comment.
Would it make sense to drop the 'at' from the header or reword it some other way? Ended at: 5 minutes ago feels weird, but maybe it's just me.
There was a problem hiding this comment.
Just Ended should work fine, or?
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
adamruzicka
approved these changes
Jul 11, 2017
|
Thanks @tbrisker |
|
and @adamruzicka for review |
|
(sorry for the post-merge review, I didn't catch the issue til just now 🎣 ) If a task is in paused state, it won't have an ended_at and the widget will error. I had to use this line instead:
Other than that, the change looks good. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made the table fixed with tooltips on overflow.