Fixes #30969 - replace deprecated mount_react_component #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Thanks @MariaAga ! I believe we need to keep the task-details class around though.
| @@ -15,9 +15,4 @@ | |||
| switcher_item_url: foreman_tasks_task_path(:id => ':id') | |||
| ) %> | |||
|
|
|||
|
|
|||
| <div class="task-details" id="foremanTaskDetails"> | |||
There was a problem hiding this comment.
We've got some css styles on task-details namely .task-details pre { ... }.
I'd choose an easy option and just leave the div, without the id="" part and put the mount inside.
But we can change css, or add the class into the component itself.
There was a problem hiding this comment.
I changed the css so it will be more specific, thanks for the suggestion!
MariaAga
force-pushed
the
refactor/mount-react
branch
from
87626d6
to
f40da4c
Compare
ezr-ondrej
approved these changes
Oct 14, 2020
|
@adamruzicka could you press the button please? This works nicely and I believe this is ready to get in :) |
|
With pleasure |
adamruzicka
approved these changes
Oct 15, 2020
|
Thank you @MariaAga & @ezr-ondrej ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theforeman/foreman#7874
mount_react_componentshould be replaced byreact_component