Fixes #30544 - deprecate mount_react_component #7874
Conversation
|
Issues: #30544 |
|
Would it make sense to first change the current places where this helper is used, at least in core, before marking it as deprecated? |
Yes, I will add individual issues for each instance and try to split the effort. |
|
I think that individual Redmine issues will greatly pollute the changelog and make it much less clear what was the actual change. Can't you make a list and use @tbrisker we have a similar thing in the installer and I'm wondering what you think is a best practice here. |
It makes sense to me in such cases where it's clear that there are multiple steps to get one issue resolved, on the other hand it is sometimes useful to break down a larger task into smaller ones that can be done separately - for example see https://projects.theforeman.org/issues/28278. So I would say that IMHO it depends on the size and complexity of the effort. |
|
IMO the benefit of having individual Redmine issues is so developers can assign themself and we can split the effort. |
|
You can make a Redmine tracker that brings together all the individual issues |
Yes we have this one: https://projects.theforeman.org/issues/30544 |
ezr-ondrej
force-pushed
the
ref/deprecate_mount_react_component
branch
from
4d440c0
to
4695a9a
Compare
|
I've rebased for you, let see what the tests are going to say now :) |
|
There seems to be one more, that slipped our attention: #8040 |
|
There are plugins that also use @LaViro Not sure where you track issues in rh-cloud but there are a few uses there: https://github.com/theforeman/foreman_rh_cloud/search?q=mount_react_component |
We also support older versions and its easier for us to do the CPs, On what foreman version would it be deprecated? |
I hope we can make it in |
|
The |
app/helpers/reactjs_helper.rb
Outdated
| @@ -1,5 +1,6 @@ | |||
| module ReactjsHelper | |||
| def mount_react_component(name, selector, data = [], opts = {}) | |||
| Foreman::Deprecation.deprecation_warning('2.5', 'use #react_component instead #mount_react_component') | |||
There was a problem hiding this comment.
| Foreman::Deprecation.deprecation_warning('2.5', 'use #react_component instead #mount_react_component') | |
| Foreman::Deprecation.deprecation_warning('2.5', 'use #react_component instead of #mount_react_component') |
|
Opened theforeman/foreman_rh_cloud#357 to refactor it in |
ezr-ondrej
force-pushed
the
ref/deprecate_mount_react_component
branch
from
4695a9a
to
88263ae
Compare
|
I've rebased again, let see 👍 |
Deprecate the ReactjsHelper#mount_react_component, please use ReactjsHelper#react_component instead.
ezr-ondrej
force-pushed
the
ref/deprecate_mount_react_component
branch
from
88263ae
to
e9ea416
Compare
|
I've added Katello ticket: https://projects.theforeman.org/issues/31122 with PR, that leaves us only with OpenSCAP plugin in our organization. I think we are ready to go 👍 |
There was a problem hiding this comment.
I believe this is ready to get in 👍
Thanks @sharvit for kicking this off, thanks @MariaAga, @amirfefer, @xprazak2, @LaViro and @jeremylenz for the joined effort to get rid of the old mounter usage.
There was a problem hiding this comment.
thanks @sharvit @ezr-ondrej and everyone involved in this effort!
Deprecate the ReactjsHelper#mount_react_component,
please use ReactjsHelper#react_component instead.
Please wait for the next develop version before merging.