Fixes #34917 - do not load model constants too early #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails do not handle well when namespaced models are loaded prior any unnamespaced one. Loading models too soon in initialization process will be imposible with Zeitwerk, so it is good practice anyway.
1 task
jeremylenz
approved these changes
May 12, 2022
There was a problem hiding this comment.
I tested this and confirm that it un-breaks Rails server
- Foreman checked out Fixes #34305 - stop creating settings in DB foreman#9050
- Katello on master
Fixes the error PG::UndefinedTable: ERROR: relation "application_records" does not exist when attempting to run migrations or start the rails server.
ACK 👍
|
Thanks @jeremylenz for the debugging session that has lead to this PR, I'm bit worried there will be more instances of this and I still did not figured out why is this happening :( |
adamruzicka
approved these changes
May 13, 2022
|
Thank you @ezr-ondrej & @jeremylenz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails do not handle well when namespaced models are loaded prior any unnamespaced one.
EDIT: please let me look smart and don't ask why 🙏
Loading models too soon in initialization process will be imposible with Zeitwerk, so it is good practice anyway.