Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unique IDs to menu and submenu entries. #1038

Closed
wants to merge 1 commit into from
Closed

Adding unique IDs to menu and submenu entries. #1038

wants to merge 1 commit into from

Conversation

omaciel
Copy link
Contributor

@omaciel omaciel commented Nov 18, 2013

Unique IDs are crucial for proper UI automation.

Unique IDs are crucial for proper UI automation.
@skottler
Copy link

Thanks @omaciel! Can you create a ticket for this at http://projects.theforeman.org and then add the ID to the commit?

@omaciel
Copy link
Contributor Author

omaciel commented Nov 18, 2013

@ohadlevy
Copy link
Member

I know this conflicts with #987 but @abenari would it be possible for you to merge it as part of it?

@domcleal
Copy link
Contributor

It's now fixed in the menu redesign PR, but the logout menu bit I think is still useful, so we'll keep this open until the menu redesign's merged and rebase on top.

@abenari
Copy link
Member

abenari commented Nov 19, 2013

Ids for testing are good idea.
I have added it to #987, it is working for the user menu too.
Can close this PR once #987 is in and @omaciel confirms that it solves his issue.

@domcleal
Copy link
Contributor

@omaciel the other PR's been merged now and I see ID attrs on all menu items. Could you confirm if there's anything more you need to add here? Thanks!

@omaciel
Copy link
Contributor Author

omaciel commented Nov 22, 2013

@domcleal will install and test it as soon as nightly build is available. I wonder if my PR is relevant anymore as I believe the default will be to add "menu_item_*" to the menus now?

@omaciel
Copy link
Contributor Author

omaciel commented Nov 22, 2013

@domcleal @abenari The sub-menu items all have unique IDs, which is awesome, but the first level menus (i.e. Monitor, Hosts, etc) don't. Could you also add IDs to those?

@omaciel
Copy link
Contributor Author

omaciel commented Nov 22, 2013

Also, the menu for the user account (where you have the signout link) needs an ID.

@domcleal
Copy link
Contributor

Added these in #1049.

@domcleal domcleal closed this Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants