New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unique IDs to menu and submenu entries. #1038
Conversation
Unique IDs are crucial for proper UI automation.
Thanks @omaciel! Can you create a ticket for this at http://projects.theforeman.org and then add the ID to the commit? |
Here you go @skottler http://projects.theforeman.org/issues/3684 |
It's now fixed in the menu redesign PR, but the logout menu bit I think is still useful, so we'll keep this open until the menu redesign's merged and rebase on top. |
@omaciel the other PR's been merged now and I see ID attrs on all menu items. Could you confirm if there's anything more you need to add here? Thanks! |
@domcleal will install and test it as soon as nightly build is available. I wonder if my PR is relevant anymore as I believe the default will be to add "menu_item_*" to the menus now? |
Also, the menu for the user account (where you have the signout link) needs an ID. |
Added these in #1049. |
Unique IDs are crucial for proper UI automation.