fixes #3790 - Added support for isolated engine to foreman menu. #1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolated engines needs to run the route helpers in the plugin context. Since the menu is common to the plugins and the main app, menu items urls needs to be computed at the correct context.
This patch add option to the 'menu' method.
An isolated engine needs to declare
for each menu item.
I was experimenting with declaring an engine is isolated instead of repeating the declaration for each menu item but favored the proposed solution because it lets an isolated plugin writer to interact with foremans controllers too.
This pull request replaces PR #1075