Fixes #4370 - Filters list show permissions

[dLobatog]

http://projects.theforeman.org/issues/4370

[dmitri-d]

I'm getting "Invalid search query: the field 'permissions' in the order statement is not valid field for search" when attempting to sort by permissions -- filter model is missing corresponding scoped search definition.

I'm not sure how useful this sorting order is, perhaps it's better to leave it out? Would it be better to allow filtering based on permission name?

[dLobatog]

@thomasmckay ^^

[thomasmckay]

@elobato Not sorting seems fine to me. I assume search works?

[dmitri-d]

Search on permissions isn't working atm; should be straightforward to add though.

[dLobatog]

I'll add scoped_search to permissions then.

[domcleal]

Some of the columns (like the last one with dropdown + button) look rather squashed to me when viewing something like the manager role.

[dLobatog]

I'm not quite sure how to handle searches with spaces, queries should be made like this now:
role = "Manager" and permission = edit_organizations

It's understandable for us devs but regular users will see stuff like "Edit organizations" in the permissions column, should I better change that to "edit_organizations" like what users see when editing the filter?

[domcleal]

I think edit_organizations is clearer, keep it consistent.

[dmitri-d]

+1 to what @domcleal said.

[dLobatog]

Ask and you shall receive. 😄

[dmitri-d]

Sorting by permissions is still enabled, but isn't working: "Invalid search query: the field 'permissions' in the order statement is not valid field for search". Filtering by permission name works, but values are not being auto-suggested as for other fields (I tried it -- looks helpful, although the auto-suggest list can get pretty long).

[dLobatog]

I disabled sorting by permissions.

[domcleal]

Merged as 46da92f for Foreman 1.5.0, thanks @elobato!