fixes #5172 - typo SETTINGS[:location_enabled] instead of :locations_enabled causes default location select box not to be visible

[isratrade]

No description provided.

[isratrade]

@elobato, check your settings.yaml file. It seems the only way for your commit 070b83f to have worked in your local dev environment is if you had location_enabled rather that locations_enabled

[dLobatog]

I had that setting, sorry. Can you change it to SETTING[:locations_enabled] as per @domcleal 's comment #1191 (diff) ?

[isratrade]

The helper method show_location_tab? uses SETTINGS[:locations_enabled]

  def show_location_tab?
    SETTINGS[:locations_enabled] && User.current.allowed_to?(:view_locations)
  end

[dLobatog]

Yeah, I used it at first too, but the reason why @domcleal didn't want to use the helper was that we don't want users to need special permissions (:view_locations) to change their own default taxonomies.

[isratrade]

re-committed. It makes senses not to have (:view_conditions) to change default taxonomies.

[dLobatog]

Merged as 936bab0 , thanks @isratrade !