Fixes #7743 - ensure name is unique in scope of major and minor #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_equal(operatingsystems(:centos5_3).name, operatingsystem.name) | ||
| assert_equal(operatingsystems(:centos5_3).major, operatingsystem.major) | ||
| assert_equal(operatingsystems(:centos5_3).minor, operatingsystem.minor) | ||
| refute operatingsystem.valid? |
There was a problem hiding this comment.
maybe use FactoryGirl to create two operating systems that are tests?
If it's planned to remove all or most of the fixtures it would be easier if new tests avoided them
|
tested, works for me 👍 |
| @@ -29,10 +29,11 @@ class Operatingsystem < ActiveRecord::Base | |||
| has_many :trends, :as => :trendable, :class_name => "ForemanTrend" | |||
| attr_name :to_label | |||
| validates :minor, :numericality => {:greater_than_or_equal_to => 0}, :allow_nil => true, :allow_blank => true | |||
| validates :name, :presence => true, :format => {:with => /\A(\S+)\Z/, :message => N_("can't contain white spaces.")} | |||
| validates :name, :presence => true, :format => {:with => /\A(\S+)\Z/, :message => N_("can't contain white spaces.")}, | |||
| :uniqueness => { :scope => [:major, :minor], :message => N_("Operating system version exists")} | |||
There was a problem hiding this comment.
nitpick: "Operating system version already exists" is better, IMHO
|
Same concern as expressed in #1962 : Need a migration to handle existing duplicate names. |
|
@shlomizadok please rebase |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Merged as f320bbc, thanks @shlomizadok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.