Fixes #8498 - Add root_pass accessibility to finish scripts #1983

TJM · 2014-11-26T05:54:29Z

This fixes the ability to access the root_pass attribute, and ensures that its loaded. It also includes an updated default kickstart template that actually sets the root password on a "image" based install. (with the assumption that the root password will be set by the provision script otherwise so setting it again would be unnecessary). It also fixes the check to see if the password pasted was already hashed. (probably could use some documentation there)

Since the "finish" script will not get loaded automatically, in order to test this, add the following to a finish script for a centos/rhel/fedora based install.. I am not sure if it works on debian or gentoo based images.

<% if @host.provision_method == 'image' &&  ! root_pass.blank? -%>
# Install the root password
echo 'root:<%= root_pass -%>' | /usr/sbin/chpasswd -e
<% end -%>

This is a resubmit of my previous PR #1982 due to bad commit messages.

ohadlevy · 2014-11-26T07:05:36Z

[test]

dLobatog · 2014-11-26T11:51:38Z

@TJM Tests are failing, check out the results in jenkins or run rake test to try it out yourself.

TJM · 2014-11-26T18:47:01Z

@elobato : The tests are failing directly in the "develop" branch too. I thought that was a "known issue" ?

results from "develop" branch:

(snip)
1166 tests, 3030 assertions, 6 failures, 20 errors, 2 skips
Coverage report generated for Unit Tests to /home/vagrant/foreman/coverage. 11070 / 16838 LOC (65.74%) covered.
The Apipie cache is turned off. Enable it and run apipie:cache rake task to speed up API calls.
ldapname is deprecated and will be removed in a future version
Workaround for RbVmomi may not work as ComputeResource is already loaded: ComputeResource
/home/vagrant/foreman/config/initializers/rbvmomi.rb:20: warning: toplevel constant ComputeResource referenced by RbVmomi::VIM::ComputeResource
(snip .. etc etc etc, pages and pages of errors)

domcleal · 2014-11-27T09:30:53Z

There aren't any known failures.. those messages don't really show the problem, can you gist the whole lot perhaps? Do check you have organisations+locations enabled in settings.yml, as these are required when running the tests at least (not necessary normally).

Else, click the Details link next to "Job result: FAILURE", click the red "foreman", click the # number next to test_develop_pr_core and it shows a list of failed tests.

dLobatog · 2014-11-28T00:07:36Z

@TJM

Here's the link to the failures in this PR test_develop_pr_core
develop is green.

TJM · 2014-11-28T19:20:10Z

Hi @elobato, Sorry about that. I got some help from @ohadlevy Thursday (morning for me), it turns out that the failures I was seeing were related to me running bundle install --without-postgres --without-libvirt ... in addition to that, you cannot just use the settings.yaml.example like the Contribute page says, you have to edit it and enable locations and organizations. Now that I can get tests to succeed on "develop" I am able to make them fail in the same way that jenkins sees on my branch. SO, now I just need to figure out what is causing it to fail :)

dLobatog · 2014-11-30T23:17:01Z

[test]

domcleal · 2014-12-02T12:39:34Z

[test]

TJM · 2014-12-02T23:27:09Z

So, I am guessing that SQL failure was not related to my code :)

ohadlevy · 2014-12-23T09:08:06Z

@TJM would you mind rebasing this PR ? thanks

TJM · 2014-12-23T17:03:50Z

Hi guys, I think that someone potentially did a git push --force to the "develop" branch, which is what caused this to get all out of whack. It was somewhere around the "rails 3.2.21" stuff. I did have a conflict with the host_managed.rb, which was expected and I fixed that, but I just took the "HEAD" version of the Gemfile because I had not previously changed that.

dLobatog · 2014-12-23T17:36:11Z

[test]

unorthodoxgeek · 2014-12-28T10:26:23Z

app/views/unattended/kickstart/finish.erb

@@ -19,6 +20,11 @@ oses:
  puppet_enabled = pm_set || @host.params['force-puppet'] && @host.params['force-puppet'] == 'true'
 %>

+<% if @host.provision_method == 'image' &&  ! root_pass.blank? -%>


if @host.provision_method == 'image' && root_pass.present?

is more readable IMHO.

agreed! I am still learning what methods are available, I hated "not blank" :)

unorthodoxgeek · 2014-12-28T10:31:57Z

@ohadlevy - I think this can be merged.
that minor styling issue I commented on is not critical.

ohadlevy · 2014-12-28T11:14:03Z

app/views/unattended/kickstart/finish.erb

@@ -19,6 +20,11 @@ oses:
  puppet_enabled = pm_set || @host.params['force-puppet'] && @host.params['force-puppet'] == 'true'
 %>

+<% if @host.provision_method == 'image' &&  ! root_pass.blank? -%>
+# Install the root password
+echo 'root:<%= root_pass -%>' | /usr/sbin/chpasswd -e


since chpasswd is in shadow-utils I assume that's going to work, just wondering if there is a version of the os that this wont work, an alternative solution would be:

echo -e "<%=root_pass %>\n<%= root_pass %>" | passwd --stdin root

I am fairly sure that using passwd --stdin is going to expect the actual password, while chpasswd actually is expecting the hashed password, which is why I chose that.

@TJM yep, you are right, scratch that then :)

ohadlevy · 2014-12-29T21:23:17Z

[test]

TJM · 2014-12-29T23:10:14Z

app/models/concerns/host_common.rb

@@ -116,9 +116,9 @@ def crypt_root_pass
                       end

    if unencrypted_pass.present?
-      self.root_pass = unencrypted_pass.starts_with?('$') ? unencrypted_pass :
+      self.root_pass = !!(unencrypted_pass.match('^\$\d+\$.+\$.+')) ? unencrypted_pass :


NOTE: this fixes another issue I had with a root password that started with "$" not being hashed. I don't know if there should be a separate bug report for that? (probably)

WIll pull this change out, it needs to be its own issue

dLobatog · 2014-12-30T07:54:31Z

@TJM 👍 from my side. Please add a few unit tests and we're all set 😄 !

dLobatog · 2015-01-26T19:50:58Z

app/views/unattended/kickstart/finish.erb

@@ -1,3 +1,4 @@
+#!/bin/bash


I believe shebangs are not necessary in this kind of template

I think this one will go away with rebase

…kickstart)

dLobatog · 2015-01-26T21:41:33Z

Merged c47be8a , 3 months later.. thanks @TJM! 🙇

theforeman-bot added Not yet reviewed Needs testing labels Nov 26, 2014

dLobatog changed the title ~~8498 Add root_pass accessibility to finish scripts~~ Fixes #8498 - Add root_pass accessibility to finish scripts Nov 26, 2014

dLobatog added Waiting on contributor and removed Not yet reviewed Needs testing labels Nov 26, 2014

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Nov 28, 2014

TJM force-pushed the 8498-root_pass branch from b136568 to dc43122 Compare December 23, 2014 16:55

unorthodoxgeek reviewed Dec 28, 2014
View reviewed changes

ohadlevy reviewed Dec 28, 2014
View reviewed changes

TJM reviewed Dec 29, 2014
View reviewed changes

dLobatog removed Needs testing Needs re-review labels Dec 30, 2014

dLobatog added the Waiting on contributor label Dec 30, 2014

dLobatog reviewed Jan 26, 2015
View reviewed changes

Tommy McNeely added 3 commits January 26, 2015 14:29

fixes theforeman#8498 - move the password field down to its own div

c0f69d2

fixes theforeman#8498 - Allows root password to be set in finish scripts

bb7a966

fixes theforeman#8498 - set root password on image installs (default …

bb8f75d

…kickstart)

TJM force-pushed the 8498-root_pass branch from d7ffe5b to bb8f75d Compare January 26, 2015 21:33

fixes theforeman#8498 - remove shebang per eLobato

77f00cf

dLobatog closed this Jan 26, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #8498 - Add root_pass accessibility to finish scripts #1983

Fixes #8498 - Add root_pass accessibility to finish scripts #1983

TJM commented Nov 26, 2014

ohadlevy commented Nov 26, 2014

dLobatog commented Nov 26, 2014

TJM commented Nov 26, 2014

domcleal commented Nov 27, 2014

dLobatog commented Nov 28, 2014

TJM commented Nov 28, 2014

dLobatog commented Nov 30, 2014

domcleal commented Dec 2, 2014

TJM commented Dec 2, 2014

ohadlevy commented Dec 23, 2014

TJM commented Dec 23, 2014

dLobatog commented Dec 23, 2014

unorthodoxgeek Dec 28, 2014

TJM Dec 29, 2014

unorthodoxgeek commented Dec 28, 2014

ohadlevy Dec 28, 2014

TJM Dec 29, 2014

ohadlevy Dec 29, 2014

ohadlevy commented Dec 29, 2014

TJM Dec 29, 2014

TJM Jan 26, 2015

dLobatog commented Dec 30, 2014

dLobatog Jan 26, 2015

TJM Jan 26, 2015

dLobatog commented Jan 26, 2015

Fixes #8498 - Add root_pass accessibility to finish scripts #1983

Fixes #8498 - Add root_pass accessibility to finish scripts #1983

Conversation

TJM commented Nov 26, 2014

ohadlevy commented Nov 26, 2014

dLobatog commented Nov 26, 2014

TJM commented Nov 26, 2014

domcleal commented Nov 27, 2014

dLobatog commented Nov 28, 2014

TJM commented Nov 28, 2014

dLobatog commented Nov 30, 2014

domcleal commented Dec 2, 2014

TJM commented Dec 2, 2014

ohadlevy commented Dec 23, 2014

TJM commented Dec 23, 2014

dLobatog commented Dec 23, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unorthodoxgeek commented Dec 28, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohadlevy commented Dec 29, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dLobatog commented Dec 30, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dLobatog commented Jan 26, 2015