Fixes #9231 - Require English lib and fix ENC failure #2131
Conversation
daviddavis
changed the title
daviddavis
changed the title
daviddavis
force-pushed
the
temp/20150205084616
branch
from
15c7539
to
307d1f0
Compare
|
There's also the instance in app/host/managed.rb changed here: 4f7a4d0#diff-29 (Did you mean to keep English?) |
|
Yea, I added the English lib. If you'd rather I went back to the original globals, I can do that. Or if you want me to refactor 4f7a4d0#diff-29, I can do that too. |
|
FYI, there's also other places that require English too like 4f7a4d0#diff-53e1a0d0a8734476a8eb9b7e66b59d4aL164 (or reversion). |
|
Ah cool, that's fine by me. I thought CHILD_STATUS was core, interesting! |
| render :text => _('Unable to generate output, Check log files\n'), :status => 412 and return | ||
| logger.warn "Failed to generate external nodes for #{@host} with #{e}" | ||
| logger.debug(e.backtrace.join("\n")) | ||
| render :text => _('Unable to generate output, Check log files'), :status => 412 and return |
There was a problem hiding this comment.
Nitpick, can you use the symbol instead of the code? :precondition_failed
|
@daviddavis 👍 , but is this still WIP? |
dLobatog
added
Waiting on contributor
and removed
Not yet reviewed
Needs testing
labels
daviddavis
force-pushed
the
temp/20150205084616
branch
from
307d1f0
to
2a9ba45
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
daviddavis
changed the title
|
[test] |
|
Updated. Should be ready to go. |
|
Merged as 350a041 , thanks @daviddavis . Notice I removed the '#failed' comment as it was very redundant |
No description provided.