-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #9231 - Require English lib and fix ENC failure #2131
Conversation
15c7539
to
307d1f0
Compare
There's also the instance in app/host/managed.rb changed here: 4f7a4d0#diff-29 (Did you mean to keep English?) |
Yea, I added the English lib. If you'd rather I went back to the original globals, I can do that. Or if you want me to refactor 4f7a4d0#diff-29, I can do that too. |
FYI, there's also other places that require English too like 4f7a4d0#diff-53e1a0d0a8734476a8eb9b7e66b59d4aL164 (or reversion). |
Ah cool, that's fine by me. I thought CHILD_STATUS was core, interesting! |
render :text => _('Unable to generate output, Check log files\n'), :status => 412 and return | ||
logger.warn "Failed to generate external nodes for #{@host} with #{e}" | ||
logger.debug(e.backtrace.join("\n")) | ||
render :text => _('Unable to generate output, Check log files'), :status => 412 and return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, can you use the symbol instead of the code? :precondition_failed
@daviddavis 👍 , but is this still WIP? |
307d1f0
to
2a9ba45
Compare
[test] |
Updated. Should be ready to go. |
Merged as 350a041 , thanks @daviddavis . Notice I removed the '#failed' comment as it was very redundant |
No description provided.