fixes #9551 - checking the encryption format so osx doesn't fail

[unorthodoxgeek]

No description provided.

[lzap]

Before I even start digging - I don't like this at all :-)

Can you paste the actual error you encounter and some description what the problem is? I believe MacOS engineers created "better" crypt function which has different behavior.

[unorthodoxgeek]

@lzap - this is actually the second time we encounter this. see http://apidock.com/ruby/String/crypt
because the #crypt method relies on the native libc library, stuff can work differently on different machines.
*nix have an output which looks sort of like "$1$default$hCkak1kaJPQILNmYbUXhD0"
Darwin's libc has to be different, because apple, right? so their output will resemble "$fgbhdfgheirgre"

we can either check the output or stop relying on the output, we can't ignore the fact that #crypt will work different on different machines.

[lzap]

Can't we simply change the regexp to ^\$\d ? That will match against Linux and MacOS.

One could possibly have a password starting with $1mypass but that is very fragile password in general.

Alternatively let's detect OS properly and in case of MacOS change the regexp. Not following introduction of is_actually_encrypted.

[unorthodoxgeek]

actually, the variable is the right thing to do here anyway, as it prevents code duplication :)

[dLobatog]

[test]

[lzap]

Ok, can we get rid of

PasswordCrypt.passw_crypt("test_this").match('^\$\d+\$.+\$.+')

and do this test during application load (class variable or constant in the utility lib/ module). Platforms do not change during runtime :-)

[unorthodoxgeek]

@lzap - done

[lzap]

Can we do more transparent method name? I would suggest crypt_unix_compatible or if we want to be precise then crypt_mcf_compatible (Modular Crypt Format defacto-standard: http://pythonhosted.org/passlib/modular_crypt_format.html). Definitely not "*nix" because MacOS is also unix-like OS.

[lzap]

Looks fine! Thanks.

[lzap]

Merged as 526e02f thanks!