fixes #10298 - handle destroyed but present interfaces #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deleting a host and DHCP orchestration is removing reservations for NICs,
it generates a dhcp_record that contains next-server data. Determining the
next-server IP causes the primary interface to be fetched for DNS resolution,
to resolve the next-server hostname:
app/models/host/base.rb:390:in `get_interface_by_flag'
app/models/host/base.rb:253:in `primary_interface'
app/models/host/managed.rb:130:in `dns_ptr_record'
app/models/host/managed.rb:838:in `to_ip_address'
app/models/nic/managed.rb:16:in `to_ip_address'
app/models/concerns/orchestration/dhcp.rb:49:in `boot_server'
app/models/concerns/orchestration/dhcp.rb:72:in `dhcp_attrs'
app/models/concerns/orchestration/dhcp.rb:18:in `dhcp_record'
app/models/concerns/orchestration/dhcp.rb:32:in `del_dhcp'
get_interface_by_flag no longer attempts to modify the interface when it is
being deleted.
domcleal
force-pushed
the
10298-delete-dns-lookup
branch
from
63a45e1
to
8af4be0
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a host and DHCP orchestration is removing reservations for NICs,
it generates a dhcp_record that contains next-server data. Determining the
next-server IP causes the primary interface to be fetched for DNS resolution,
to resolve the next-server hostname:
get_interface_by_flag no longer attempts to modify the interface when it is
being deleted.
Bit of a pain to reproduce the stack trace above. You need a) DHCP orchestration, b) reverse DNS orchestration, c) TFTP orchestration with either the proxy's :tftp_servername set to a hostname or the smart proxy added to Foreman with a hostname (using an IP here will not reproduce it).