fixes #10720 - Adds API to get host vm attributes #2440
Conversation
|
There were the following issues with the commit message:
Guidelines are available on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
hufman
changed the title
|
[test] |
| @@ -180,6 +180,7 @@ Trey Dockendorf <treydock@tamu.edu> | |||
| Unknown <flo@WKS-W7-LDN-0034.tradition.int> | |||
| Vanya Jauhal <vanyajauhal1995@gmail.com> | |||
| Walden Raines <walden@redhat.com> | |||
| Walter Huf <hufman@google.com> | |||
There was a problem hiding this comment.
This change not necessary, it gets autogenerated on every release 😄
There was a problem hiding this comment.
Ah, I didn't know that.
|
I've triggered Jenkins tests with the previous comment. Thanks for your contribution @hufman ! |
|
Looks like you'll have to define permissions, tests failed, see access_permissions.rb |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
This exposes an API to fetch a host's vm_compute_attributes, such as vmware cpus and memory. It lives at a separate endpoint because it involves a fetch for data from the compute resource, and may have different performance characteristics than the database.
|
Happy Monday! I incorporated your suggestions. |
|
[test] |
|
@hufman Works pretty well, I'll rereview the code and merge if Mr. Jenkins agrees it's 👍 |
|
Oh no! I built the response to look like the v1 api response, but I added it to the v2 api space. Can I add a patch to fix this? Basically removing the outer 'vm_compute_attributes' level so it's just the actual data. |
|
@hufman sure, please just send us another PR. Thanks! |
This exposes an API to fetch a host's vm_compute_attributes, such as vmware cpus and memory. It lives at a separate endpoint because it involves a fetch for data from the compute resource, and may have different performance characteristics than the database.