Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12034 - scope nics to validate uniqueness against #2775

Closed
wants to merge 1 commit into from

Conversation

ares
Copy link
Member

@ares ares commented Oct 1, 2015

No description provided.

@ares
Copy link
Member Author

ares commented Oct 1, 2015

Hehe #12034 fixes #11034, I hope there won't be #13034 needed for this one :-)

@dLobatog
Copy link
Member

dLobatog commented Oct 2, 2015

Merged as 5863e06, thanks @ares!

@dLobatog dLobatog closed this Oct 2, 2015
@lzap
Copy link
Member

lzap commented Oct 6, 2015

Discovery creates all interfaces as Managed, I wonder if it's the time to create our own NIC type.

@ares
Copy link
Member Author

ares commented Oct 6, 2015

@lzap I don't think that would be a good idea, think about how hard is converting Host::Discovered to Host::Managed during provisioning, you'd have to do the same with nics... I thought discovered interface were untouched since they are imported as unmanaged (managed: false). Unfortunately but luckilly it does not have anything to do with the class name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants