refs #12179 - refactoring extracted strings for host parameters #2948
Conversation
| @@ -165,7 +165,7 @@ def parent_params(include_source = false) | |||
| # otherwise we might be overwriting the hash in the wrong order. | |||
| groups = Hostgroup.sort_by_ancestry(Hostgroup.includes(:group_parameters).find(ids)) | |||
| groups.each do |hg| | |||
| hg.group_parameters.each {|p| hash[p.name] = include_source ? {:value => p.value, :source => N_('hostgroup').to_sym, :safe_value => p.safe_value, :source_name => hg.title} : p.value } | |||
| hg.group_parameters.each {|p| hash[p.name] = include_source ? {:value => p.value, :source => p.associated_type.to_sym, :safe_value => p.safe_value, :source_name => hg.title} : p.value } | |||
There was a problem hiding this comment.
Why does :source here and elsewhere call .to_sym?
There was a problem hiding this comment.
I don't think there's any good reason for this.
|
test failures are unrelated |
| @@ -160,6 +160,12 @@ def get_element_and_element_name(lookup_value) | |||
| element_name = '' | |||
| lookup_value.match.split(LookupKey::KEY_DELM).each do |match_key| | |||
| lv_element, lv_element_name = match_key.split(LookupKey::EQ_DELM) | |||
| case lv_element | |||
There was a problem hiding this comment.
I'm a little unsure about this because this is actually the matcher defined by the user in the Puppet class settings. To change it for some objects and not others might be confusing, and open up another can of worms.
There was a problem hiding this comment.
I'm fine with not changing this but that means you would look at the additional information for smart class parameters and see 'hostgroup' and in global parameters 'host group'.
There was a problem hiding this comment.
Yeah, I understand. I don't mind if you want to address it (separately?), but I'd have more comments - since we'd need to translate everything, not just these two resource types.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
Refs theforeman#2948 - Add sp_ host attributes to jail test
@domcleal I changed
host_params.rbas you requested and fixed the rest of the rest of the parameters shown on host edit form to be consistent.This might be overkill, in which case I'll close the pr.