fixes #2023 - Don't try to save os=nil in the fact importer #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried to address all possible places where empty set of facts (e.g. we dont have the facts just yet as its a brand new install) could lead to the operating system value disappering. i believe the issue happened because of a boolean == string compareing (e.g. some left overs in cache might lead to if "false" which is true. I've also ensured that we get an exception if the operating system value is empty or if it does not pass validations.
| @@ -116,7 +116,7 @@ def self.import(yaml) | |||
| r.import_log_messages report | |||
| # if we are using storeconfigs then we already have the facts | |||
| # so we can refresh foreman internal fields accordingly | |||
| host.populateFieldsFromFacts if Setting[:using_storeconfigs] | |||
| host.populateFieldsFromFacts if Setting[:using_storeconfigs] == false | |||
|
I'd like to include domcleal@fc6f072. Without it, the setting default is getting initialised as a string: This seems to be leaking through if there's no user-specified value. |
|
Code looks solid to me :) |
|
merged including dominics patch thanks! |
LiorKGOW
pushed a commit
to LiorKGOW/foreman
that referenced
this pull request
Oct 20, 2022
…an#318) * Fixes #28463 - Fix missing roles in the assigned roles list * Fixes #28463 - Fix missing roles in the assigned roles list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to address all possible places where empty set of facts (e.g. we
dont have the facts just yet as its a brand new install) could lead to the
operating system value disappering.
i believe the issue happened because of a boolean == string compareing (e.g.
some left overs in cache might lead to if "false" which is true.
I've also ensured that we get an exception if the operating system value is empty
or if it does not pass validations.