Fixes #10605 - handle logout accessed by GET #3419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -210,7 +210,7 @@ class UsersControllerTest < ActionController::TestCase | |||
| @controller.stubs(:available_sso).returns(@sso) | |||
| @controller.stubs(:get_sso_method).returns(@sso) | |||
| get :extlogin, {}, {} | |||
| get :logout, {}, {} | |||
| post :logout, {}, {} | |||
There was a problem hiding this comment.
fixes test that worked accidentally
There was a problem hiding this comment.
What was the accident? How do we prevent from happening again?
There was a problem hiding this comment.
What was the accident?
GET for :logout didn't exist until now. Functional tests don't go through routes so even PUT :logout would work. But now when GET got a different logic it stopped redirecting the user.
How do we prevent from happening again?
not sure, how about stop writing functional tests? :-)
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
I think all comments were addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.