Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #15336 - use i18n variable names and plural form #3616

Closed
wants to merge 1 commit into from

Conversation

domcleal
Copy link
Contributor

No description provided.

@dLobatog
Copy link
Member

dLobatog commented Jul 1, 2016

@domcleal Now it's missing the hostgroup count, sorry for missing the plural vs singular string when I merged it

@domcleal
Copy link
Contributor Author

domcleal commented Jul 1, 2016

Yeah, I removed it for a couple of reasons:

a) Primarily - gettext don't have a translation function that can handle the combination of two plural words in the same string, as there would be four different strings.
b) The change was only relating to the disassociation of hosts which can only have one org/loc, while host groups are like any other resource with multiple associations, hence it's unclear that they must be reassociated anyway.

@dLobatog
Copy link
Member

dLobatog commented Jul 1, 2016

Merged as b0f8d18, thanks @domcleal!

@dLobatog dLobatog closed this Jul 1, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants