Fixes #11749 - puppet env jquery selector more restrictive #3642
Conversation
|
Note an alternative solution is: but I think the current one is less likely to break and easier to understand. |
|
[test] |
| @@ -388,7 +388,7 @@ $(function() { | |||
|
|
|||
| function update_puppetclasses(element) { | |||
| var host_id = $("form").data('id') | |||
| var env_id = $('select[name*=environment_id]').val(); | |||
| var env_id = $('select[name*=\\[environment_id\\]]').val(); | |||
There was a problem hiding this comment.
I believe that element in this context should already be the select element.
This variable is only used to short-circuit this function if the environment is empty, I think this can be replaced by
if (element.value == '') return; at the top of the function.
I'm not sure that short-circuiting is the correct action to take in case the environment is removed, but it will fix this issue and get rid of an ugly matcher at the same time.
There was a problem hiding this comment.
Good point! Updated to reflect that, tested and seemed to have no issue.
This current jquery selector for puppet environment selection would match any select box where name included environment_id. This caused issues with katello as we put a field containing lifecycle_environment_id in the form
|
The whole logic of this and related functions should be revisited, however it is out of scope for this PR. |
|
Merged as 4eeea97, thanks @jlsherrill! |
This current jquery selector for puppet environment
selection would match any select box where name
included environment_id. This caused issues with
katello as we put a field containing lifecycle_environment_id
in the form