Fixes #16286 - Move multiselect from gem to npm #3786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,2 @@ | |||
| require('multiselect'); | |||
There was a problem hiding this comment.
Definition for rule 'no-global-assign' was not found no-global-assign
There was a problem hiding this comment.
looks like hound uses an older version of eslint that doesn't support this, what do you think about removing this rule @gailsteiger ?
There was a problem hiding this comment.
Sure, as long as you're sure that hound is using the repository rules and not the default. We can pick it up in PR code review if anyone does this, which I hope is not likely.
|
[test] |
|
👍 - please rebase @tbrisker and I'll merge, ping me if you want me to look at the PR in packaging |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@dLobatog rebased, thanks |
tbrisker
force-pushed
the
16286
branch
2 times, most recently
from
60eca5f
to
b995641
Compare
|
rebased again |
|
Thanks - I'll take care of packaging of this one 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.