fixes #2217 - initialize Regexp constants here to stop duplicate warnings #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate warnings
|
merged - thanks! |
ekohl
pushed a commit
to ekohl/foreman
that referenced
this pull request
Mar 24, 2021
Provider `cli` for `foreman_config_entry` can pass nil instead of a valid provider during prefetch if a config_entry is not found. This breaks puppet during prefetch: Error: Could not prefetch foreman_config_entry provider 'cli': undefined method `intern' for nil:NilClass /opt/ruby2.0/lib/vendor_ruby/2.0.0/puppet/type.rb:1715:in `provider' /opt/ruby2.0/lib/vendor_ruby/2.0.0/puppet/type.rb:1928:in `provider=' /var/lib/puppet/lib/puppet/provider/foreman_config_entry/cli.rb:59:in `block in prefetch' /var/lib/puppet/lib/puppet/provider/foreman_config_entry/cli.rb:53:in `each' /var/lib/puppet/lib/puppet/provider/foreman_config_entry/cli.rb:53:in `prefetch' /opt/ruby2.0/lib/vendor_ruby/2.0.0/puppet/transaction.rb:307:in `prefetch' This commit, correctly, skips provider assignment for config entries that don't exist. Closes theforemanGH-420
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.