Fixes #4509 - VMWare scsi react #4366

matanwerbner · 2017-03-09T13:30:03Z

Adding vmware storage controllers + volumes in react

@timogoebel can you please check it's working with server side? ty

mention-bot · 2017-03-09T13:30:05Z

@matanwerbner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ohadlevy, @gailsteiger and @timogoebel to be potential reviewers.

houndci-bot · 2017-03-09T13:30:33Z

webpack/stories/index.js


-    function hide() {
-      show = false;
+storiesOf('Power Status', module).add('Loading', () => (<PowerStatusInner/>)).add('ON', () => (<PowerStatusInner state="on" title="on" statusText="On"/>)).add('OFF', () => (<PowerStatusInner state="off" title="off" statusText="Off"/>)).add('N/A', () => (<PowerStatusInner state="na" statusText="No power support" title="N/A"/>)).add('Error', () => (<PowerStatusInner


Line 81 exceeds the maximum line length of 100 max-len

houndci-bot · 2017-03-09T13:30:33Z

app/controllers/hosts_controller.rb

+      deep_symbolize_keys
+    volumes = {}
+    scsi_and_vol[:volumes].each_with_index do |vol, index|
+      volumes["#{index}"] = vol


Prefer to_s over string interpolation.

ohadlevy · 2017-03-09T14:25:08Z

config/webpack.config.js

@@ -100,7 +100,7 @@ if (production) {
    hot: true
  };
  // Source maps
-  config.devtool = 'inline-source-map';
+  config.devtool = 'eval';


not related to this pr?

ohadlevy · 2017-03-09T14:26:18Z

webpack/assets/javascripts/react_app/common/colors.scss

@@ -0,0 +1 @@
+$light-grey: #efefef;


I assume this is from patternfly pallet? https://www.patternfly.org/styles/color-palette/#_

ohadlevy · 2017-03-09T14:27:42Z

webpack/assets/javascripts/react_app/components/common/forms/CommonForm.js

+
+const CommonForm = (props) => {
+  return (
+      <div className={ `form-group ${props.className || ''}` }>


cant we default the props in the const, e.g.:

const CommonForm = ({className = '', label = ''}) => { ...

ohadlevy · 2017-03-09T14:28:14Z

webpack/assets/javascripts/react_app/components/common/forms/Select.js

+};
+
+Select.defaultProps = {
+  className: ''


inconsistent with CommonForm?

ohadlevy · 2017-03-09T14:28:39Z

webpack/assets/javascripts/react_app/components/hosts/powerStatus/PowerStatus.scss

@@ -0,0 +1,11 @@
+.host-power-status {
+  &.on {
+    color: #3f9c35;


not related to the pr.

i've moved powerStatus files to their own dedicated directory inside hosts, thats the relation

TBH: based on the size of this PR, please do the restructuring in another PR that we most likely can merge quickly, then you can rebase this pr again.

ohadlevy · 2017-03-09T14:34:52Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+        value={size}
+        className="text-vmware-size"
+        onChange={updateDisk.bind(this, 'size')}
+        label={__('Size (GB)')}


should we include any basic validation (e.g. size is bigger than 0 and and is integer?)

@matanwerbner I'm OK with doing it in a separate PR, please open an issue for it.

http://projects.theforeman.org/issues/18889

ohadlevy · 2017-03-09T14:36:11Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/index.js

+    updateController({[attribute]: value});
+  };
+
+  const _updateDisk = (diskIndex, attribute, e) => {


whats the difference for this function? comment maybe?

they each dispatch a different action -
one handles changes for the controller object,
the other for disk object.

ohadlevy · 2017-03-09T14:37:48Z

webpack/assets/javascripts/react_app/redux/actions/hosts/storage/vmeware.consts.js

+  storagePod: '',
+  thinProvision: false,
+  eagerZero: false,
+  name: 'Hard disk'


should this be translated?

ohadlevy · 2017-03-09T14:38:17Z

webpack/assets/javascripts/react_app/redux/index.js

@@ -14,3 +14,9 @@ export default createStore(
  window.__REDUX_DEVTOOLS_EXTENSION__ && window.__REDUX_DEVTOOLS_EXTENSION__(),
  applyMiddleware(...middleware)
 );
+
+export const getNewStore = () => createStore(
+  reducer,


what does this do? :)

this creates a new store, it is very usefull for testing

ohadlevy · 2017-03-09T14:39:01Z

webpack/assets/javascripts/react_app/redux/reducers/hosts/powerStatus/powerStatus.fixtures.js

@@ -1,7 +1,5 @@
 import Immutable from 'seamless-immutable';
-export const initialState = Immutable({


please elaborate on all the structure changes?

state is changed to { hosts: { powerStatus: {}, storage: {} } }

timogoebel · 2017-03-09T15:15:00Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/StorageContainer.consts.js

+export const MaxDisksPerController = 15;
+export const MaxControllers = 4;
+export const ControllerTypes = {
+  VirtualBusLogicController: 'Bus Logic Parallel',


Can we get these values from the rails model?

yes, can you help put those there? my ruby is very weak

Sure, will do.

timogoebel

@matanwerbner : Thanks for taking over the PR! I did not test provisioning, yet. But I have some comments regarding the react UI.

timogoebel · 2017-03-09T15:17:06Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/index.js

+            className="cb-controller-is-selected"
+            checked={controller.isSelected}
+            onChange={_updateController.bind(this, 'isSelected')}/>
+          <label>{__('Create SCSI controller')}</label>


This checkbox should be checked by default. A VM needs at least one scsi controller or your VM won't have any storage.
I'm wondering if this checkbox is actually useful.

this is by design supplied (i will attach), it's only purpose is to decide which controllers get deleted when you click "delete controllers".

I think the design is flawed then. It would be better to have a dedicated delete button per controller (we already have a dedicated button per disk). The checkbox is very confusing. I didn't get, that it's related to the Delete Controller button.

btw: This is how this looks in VMWare. The UI is pretty bad I think, but Foreman users might be familiar with this:

(Sorry for the German language, but I guess you get the point)

@Rohoover: Do you agree? Any more comments?

@timogoebel @matanwerbner

The original design was provided here: #3979 (comment)

It was done with a low level of effort in mind. The checkboxes work similar to the Foreman tables, where items are selected before actions occur to them.

That said, alternative layouts can be done. Attached is another quick mockup with you feedback. I think it we wanted we can also add the chevrons (accordion) feature shown in the VMWare UI as well if desired.

@Rohoover : Thanks. I think with this design it's a lot more clear how to delete a controller. I like that.

I do think the chevrons are a good idea. However I don't think it's a requirement for this PR.
@matanwerbner: If you want to earn some extra points, go ahead.

i'll try to get the chevrons in soon, i have some things on my plate prior to that, so for now i just removed the checkboxes...

timogoebel · 2017-03-09T15:34:46Z

webpack/assets/javascripts/react_app/components/common/forms/Select.js

+              value={props.value}
+              onChange={props.onChange}
+      >
+        <option value="">{__('Please select')}</option>


Can we hide this if a user selects something, e.g. make this a real placeholder?

this is hidden when a user selects another options, it is regular select behavior, same as other options in the select

timogoebel · 2017-03-09T15:45:08Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+      <Select
+        label={__('Data store')}
+        value={dataStore}
+        onChange={updateDisk.bind(this, 'dataStore')}


The data doesn't update when you change the compute resource. We have a couple of VMWare compute resources that all have different datastores.
If I select one compute resource, then another one it still shows the datastores of the first one.

In addition if you create a new volume, the select fields aren't rendered as `select2´. The usage makes a lot of sense, though. We have at least 100 datastores. Select2 helps a lot.

first comment: the json seems to update OK, can you check if maybe it gets lost in the server somehow?
as for select2 - i will add for compute resource

@matanwerbner I think this is an issue as the react component is already initialized, it wont be mounted again.

afaiu steps to reproduce are:

have two different vmware compute resource

create a new host, select the first vmware, then change the compute resource to the second vmware

first vmware form will persist.

@timogoebel i believe i've solved this issue, can you pull and check again?

timogoebel · 2017-03-09T15:49:59Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+
+  return (
+    <div className="disk-container">
+      <TextInput


This should be read-only.

disk name should be read only? maybe we should no show it at all then..

the name is generated by VMWare. A user cannot change it but should be able to see it when editing a host (or he would edit the wrong disk by accident).

currently they will all show "hard disk" since it is taken from consts. should i implement an ajax request to fetch the new volume name from the server?

timogoebel · 2017-03-09T15:50:45Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+  });
+
+  return (
+    <div className="disk-container">


Disk mode parameter is missing. It was introduced in 1d5f6c2.

houndci-bot · 2017-03-13T09:37:56Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/StorageContainer.test.js

+    expect(
+      wrapper.render().find('.controller-container').length
+    ).toEqual(1);
+


Trailing spaces not allowed no-trailing-spaces

ohadlevy · 2017-03-14T09:10:55Z

webpack/assets/javascripts/react_app/redux/actions/hosts/storage/vmeware.consts.js

@@ -0,0 +1,14 @@
+export const defaultConrollerAttributes = {


typo in filename, it should be vmware.const.js

ohadlevy · 2017-03-14T09:12:25Z

webpack/assets/javascripts/react_app/constants.js

@@ -7,7 +7,12 @@ export const ACTIONS = {
  NOTIFICATIONS_EXPAND_DRAWER_TAB: 'NOTIFICATIONS_EXPAND_DRAWER_TAB',
  NOTIFICATIONS_MARK_AS_READ: 'NOTIFICATIONS_MARK_AS_READ',
  NOTIFICATIONS_MARKED_AS_READ: 'NOTIFICATIONS_MARKED_AS_READ',
-  NOTIFICATIONS_SET_REQUEST_STATUS: 'NOTIFICATIONS_SET_REQUEST_STATUS'
+  NOTIFICATIONS_SET_REQUEST_STATUS: 'NOTIFICATIONS_SET_REQUEST_STATUS',
+  CONTROLLER_ADDED: 'CONTROLLER_ADDED',


whats the difference to the STORAGE_VMWARE_ADD_CONTROLLER const?

timogoebel · 2017-03-14T13:58:55Z

@matanwerbner : I'm super busy this week. Sorry for the delay. I do want this feature, appreciate your work and will gladly help you. I'll check this out first thing next week. Please bear with me here.

houndci-bot · 2017-03-14T14:36:41Z

app/controllers/hosts_controller.rb

@@ -925,4 +926,18 @@ def host_attributes_for_templates(host)
  def csv_columns
    [:name, :operatingsystem, :environment, :model, :hostgroup, :last_report]
  end
+


Trailing whitespace detected.

timogoebel

@matanwerbner : Sorry for the delay in reviewing this. All in all, it looks good, but I found some issue while testing this.

First of all I added code to pass the controller_types to react:
timogoebel@c047ccc

Just squash that in if you want.

Second of all, the code does not pass the values of datastore or storage_pod in the JSON hash send via post. The fields are just empty strings. That's why vm creation fails right now.

When there are errors creating the VM, the react part of the form is reset.

When you edit a vm, it does not pick up the present values. The form should show the current data from the VM, e.g. if the VM has three volumes it should show three volumes. All fields except the size should be disabled as fog-vsphere (the library we use for vmware management) does not support editing any more parameters of a volume.

In addition, I left some comments inline.

And thanks again for doing this, first react form and a vmware form - that's not trivial 👍

timogoebel · 2017-03-20T15:38:52Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+      <TextInput
+        value={name}
+        onChange={updateDisk.bind(this, 'name')}
+        label={__('Disk name')}


This should be read-only or not even a text field at all. The name is interesting for users but can't actually be changed at all. Please see #4252.

timogoebel · 2017-03-20T15:40:20Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+  const selectablePods = renderOptions(storagePods);
+
+  return (
+    <div className="disk-container">


Disk mode select box is missing which was recently added. Please see #4314

added, do you want to send the possible values the same was as controller_types?

timogoebel · 2017-03-20T15:44:13Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/disk/index.js

+      />
+
+      <Select
+        label={__('Storage Pod')}


Can we hide this if there aren't any storage pods?

And if you select a storage pod we have to disable or hide the datastore select.
You can create a VM either on a storage pod or on a datastore. Storage pod has the higher priority. If a user selects a storage pod, vmware host creation will ignore what was selected as the datastore.

timogoebel · 2017-03-20T15:51:11Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/controller/index.js

+          <label>{__('Create SCSI controller')}</label>
+        </div>
+        <div className="controller-type-container col-md-4">
+          <select


This should be a select2 as well when adding a new controller.

matanwerbner · 2017-06-22T07:50:59Z

@timogoebel I've taken care of most of what you've asked, just a couple of questions:
regarding the change in select.js, what is the reason to doing that? dont we want a friendly, localized "please select" text to be shown?
second, what do you mean by debug json?

thanks

timogoebel · 2017-06-22T08:56:49Z

@matanwerbner

regarding the change in select.js, what is the reason to doing that? dont we want a friendly, localized "please select" text to be shown?

Actually, we don't have that anywhere else. We always use the pattern I suggested. But maybe @Rohoover has some advice here.
It's clear button vs. a "Please select".

second, what do you mean by debug json?

I mean the blue json output under the react form.

matanwerbner · 2017-06-22T10:42:53Z

gotcha. done.

timogoebel · 2017-06-23T08:01:05Z

@matanwerbner: Thanks. I retested this.
Some more comments:

When editing a VM, the size is now shown correctly. I posted the fix earlier:

diff --git a/app/views/compute_resources_vms/form/vmware/_base.html.erb b/app/views/compute_resources_vms/form/vmware/_base.html.erb
index 7695f0e92..46cdeb12b 100644
--- a/app/views/compute_resources_vms/form/vmware/_base.html.erb
+++ b/app/views/compute_resources_vms/form/vmware/_base.html.erb
@@ -52,6 +52,6 @@ end %>
     storagePods: vsphere_storage_pods(compute_resource),
     datastores: vsphere_datastores(compute_resource)
   },
-  volumes: f.object.volumes.map { |volume| volume.attributes.deep_transform_keys { |key| key.to_s.camelize(:lower).to_sym }.reject { |k,v| k == :Size } },
+  volumes: f.object.volumes.map { |volume| volume.attributes.merge(:size_gb => volume.size_gb).deep_transform_keys { |key| key.to_s.camelize(:lower).to_sym }.reject { |k,v| k == :Size } },
   controllers: f.object.scsi_controllers
 }.to_json) %>

Can we please disable the button alongside the other form fields when editing a host?
The code still shows the please select. :-)
I can select a disk of size 0. This doesn't work. Can we prohibit this and make 1 the minimum value?

The rest works great! Good job.

matanwerbner · 2017-06-26T07:18:48Z

@timogoebel requested changes have been commited, please check

timogoebel · 2017-06-28T11:45:24Z

@matanwerbner : Thanks. Nicely done.

@ohadlevy made some minor changes in ohadlevy@541fb96 . Could you squash them in except for the precision / decimal stuff for sizeGb? sizeGb has to be an integer. Float does not work.

Unfortunately I found another bug. When you clone a host the scsi and harddisk settings aren't cloned to the new host. :-(

Here is the fix:

diff --git a/app/models/compute_resources/foreman/model/vmware.rb b/app/models/compute_resources/foreman/model/vmware.rb
index 1b4fd6ee0..38817d624 100644
--- a/app/models/compute_resources/foreman/model/vmware.rb
+++ b/app/models/compute_resources/foreman/model/vmware.rb
@@ -553,6 +553,9 @@ module Foreman::Model
         hsh[index.to_s] = interface_attrs
         hsh
       end
+      vm_attrs[:scsi_controllers] = vm.scsi_controllers.map do |controller|
+        controller.attributes
+      end
       vm_attrs
     end

I also tested compute profiles. The volumes don't seem to get saved there. I'll investigate.

timogoebel · 2017-06-28T14:58:24Z

I also tested compute profiles.

Unfortunately, I found some more serious issues with this.
Compute profiles don't save and update correctly.
Hosts don't update correctly.

Edit: Fix posted below.

ohadlevy · 2017-06-29T06:59:00Z

@matanwerbner I've made a few minor fixes and improvements to the storybook, can you merge ohadlevy@e36314d into this PR as well? thanks!

ohadlevy · 2017-06-29T07:22:11Z

added storybook at https://rawgit.com/ohadlevy/foreman/vmware-scsi/index.html?selectedKind=Host%20VMWare%20Storage&selectedStory=default%20state%20for%20new%20host&full=0&down=1&left=1&panelRight=0&downPanel=kadirahq%2Fstorybook-addon-actions%2Factions-panel
/cc @Rohoover can you have another look at ^

timogoebel · 2017-06-30T08:37:42Z

@matanwerbner : I have completed my fix for the compute profiles: timogoebel@b1c47b9 This also contains a tiny test for the scsi controller normalization and @ohadlevy's review fixes. It does not contain ohadlevy/foreman@e36314d.

To summarize:
You need to add
ohadlevy/foreman@e36314d (needs a rebase as a new key was added to the Component's config hash in the other commit)
and
timogoebel@b1c47b9

matanwerbner · 2017-07-05T09:28:33Z

@timogoebel i'm having difficulties and errors applying your patch, can you rebase/pull from develop?
i've included @ohadlevy 's patch

ohadlevy · 2017-07-05T18:24:38Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/index.js

+    const {
+      addController,
+      controllers,
+			volumes,


nitpick: whitespace.

ohadlevy · 2017-07-05T18:25:16Z

webpack/assets/javascripts/react_app/components/hosts/storage/vmware/index.js

+    return controllers.map((controller, idx) => {
+      const controllerVolumes = volumes.filter(
+				v => v.controllerKey === controller.key
+			);


whitespace in here and below

houndci-bot · 2017-07-06T08:42:59Z

webpack/stories/index.js

@@ -14,6 +14,8 @@ import PowerStatusInner
  from '../assets/javascripts/react_app/components/hosts/powerStatus/powerStatusInner';
 import Toast
  from '../assets/javascripts/react_app/components/toastNotifications/toastListitem';
+import StorageContainer from '../assets/javascripts/react_app/components/hosts/storage/vmware';
+import * as VMWareData from './data/storage/vmware';


'VMWareData' is defined but never used no-unused-vars

houndci-bot · 2017-07-06T08:42:59Z

webpack/stories/index.js

@@ -14,6 +14,8 @@ import PowerStatusInner
  from '../assets/javascripts/react_app/components/hosts/powerStatus/powerStatusInner';
 import Toast
  from '../assets/javascripts/react_app/components/toastNotifications/toastListitem';
+import StorageContainer from '../assets/javascripts/react_app/components/hosts/storage/vmware';


'StorageContainer' is defined but never used no-unused-vars

ohadlevy · 2017-07-17T12:01:38Z

replaced by #4676 - thanks @matanwerbner :-)

theforeman-bot added Needs testing Not yet reviewed labels Mar 9, 2017

houndci-bot reviewed Mar 9, 2017

View reviewed changes

matanwerbner force-pushed the fix_4509_scsi_react branch from 03895da to cfc15f3 Compare March 9, 2017 13:34

ohadlevy reviewed Mar 9, 2017

View reviewed changes

timogoebel reviewed Mar 9, 2017

View reviewed changes

timogoebel requested changes Mar 9, 2017

View reviewed changes

theforeman-bot added Waiting on contributor and removed Not yet reviewed labels Mar 9, 2017

timogoebel changed the title ~~Fix 4509 scsi react~~ Fixes #4509 - VMWare scsi react Mar 9, 2017

matanwerbner force-pushed the fix_4509_scsi_react branch from cfc15f3 to f91c4d9 Compare March 13, 2017 09:37

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Mar 13, 2017

houndci-bot reviewed Mar 13, 2017

View reviewed changes

matanwerbner force-pushed the fix_4509_scsi_react branch from f91c4d9 to 8a7a316 Compare March 13, 2017 09:39

ohadlevy reviewed Mar 14, 2017

View reviewed changes

matanwerbner force-pushed the fix_4509_scsi_react branch 2 times, most recently from 2b91ef6 to ba7f287 Compare March 14, 2017 13:47

matanwerbner force-pushed the fix_4509_scsi_react branch from ba7f287 to 786ff5e Compare March 14, 2017 14:36

houndci-bot reviewed Mar 14, 2017

View reviewed changes

matanwerbner force-pushed the fix_4509_scsi_react branch 4 times, most recently from f410f39 to 46ae0af Compare March 15, 2017 15:42

timogoebel requested changes Mar 20, 2017

View reviewed changes

theforeman-bot removed the Needs re-review label Mar 20, 2017

matanwerbner force-pushed the fix_4509_scsi_react branch 2 times, most recently from 217aaf5 to 4b5a794 Compare June 22, 2017 07:52

matanwerbner force-pushed the fix_4509_scsi_react branch from 4b5a794 to 6c58afe Compare June 22, 2017 09:41

matanwerbner force-pushed the fix_4509_scsi_react branch 3 times, most recently from b6c83c7 to 75193d2 Compare June 25, 2017 08:15

matanwerbner force-pushed the fix_4509_scsi_react branch 3 times, most recently from bbfe56f to 820e916 Compare July 5, 2017 09:00

ohadlevy reviewed Jul 5, 2017

View reviewed changes

matanwerbner force-pushed the fix_4509_scsi_react branch from 820e916 to 453cd35 Compare July 6, 2017 08:42

houndci-bot reviewed Jul 6, 2017

View reviewed changes

matanwerbner force-pushed the fix_4509_scsi_react branch from 453cd35 to a482a57 Compare July 6, 2017 08:43

Fixes theforeman#4509 - SCSI storage controller

afe0c18

matanwerbner force-pushed the fix_4509_scsi_react branch from a482a57 to afe0c18 Compare July 6, 2017 11:24

ohadlevy mentioned this pull request Jul 17, 2017

Fixes #4509 - VMWare scsi react #4676

Merged

ohadlevy closed this Jul 17, 2017

		@@ -1,7 +1,5 @@
		import Immutable from 'seamless-immutable';
		export const initialState = Immutable({

Fixes #4509 - VMWare scsi react #4366

Fixes #4509 - VMWare scsi react #4366

Conversation

matanwerbner commented Mar 9, 2017

mention-bot commented Mar 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timogoebel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timogoebel commented Mar 14, 2017

Choose a reason for hiding this comment

timogoebel left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matanwerbner commented Jun 22, 2017

timogoebel commented Jun 22, 2017 • edited Loading

matanwerbner commented Jun 22, 2017

timogoebel commented Jun 23, 2017

matanwerbner commented Jun 26, 2017

timogoebel commented Jun 28, 2017 • edited Loading

timogoebel commented Jun 28, 2017 • edited Loading

ohadlevy commented Jun 29, 2017

ohadlevy commented Jun 29, 2017

timogoebel commented Jun 30, 2017

matanwerbner commented Jul 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohadlevy commented Jul 17, 2017

timogoebel left a comment •

edited

Loading

timogoebel commented Jun 22, 2017 •

edited

Loading

timogoebel commented Jun 28, 2017 •

edited

Loading

timogoebel commented Jun 28, 2017 •

edited

Loading