fixes #18982 - replace AC::Params#each using one-arg block #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcleal
force-pushed
the
18982-api-nested-param-iteration
branch
from
1fd342a
to
36cc045
Compare
tbrisker
suggested changes
Apr 3, 2017
| params[:host] && params[:host][:host_parameters_attributes] && params[:host][:host_parameters_attributes].each do |attribute| | ||
| attribute = attribute[1] if attribute.is_a? Array | ||
| Foreman::Deprecation.api_deprecation_warning("Field host_parameters_attributes.nested ignored") unless attribute.delete(:nested).nil? | ||
| if params[:host] && params[:host][:host_parameters_attributes] && (attrs = params[:host][:host_parameters_attributes]) |
There was a problem hiding this comment.
Why not if params[:host] && (attrs = params[:host][:host_parameters_attributes]) ?
There was a problem hiding this comment.
Thanks, PR updated with the superfluous condition removed.
ActionController::Parameters#each works differently in Rails 5.0: it no longer yields an array of [key, value] entries for hashes, only the key when given a block with arity of one. This method now iterates over only the values when passed a hash or AC::Parameters instance.
domcleal
force-pushed
the
18982-api-nested-param-iteration
branch
from
36cc045
to
11ae477
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
tbrisker
approved these changes
Apr 3, 2017
|
Thanks @domcleal ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionController::Parameters#each works differently in Rails 5.0: it no
longer yields an array of [key, value] entries for hashes, only the
key when given a block with arity of one. This method now iterates over
only the values when passed a hash or AC::Parameters instance.