Fixes #19017 - prefer request id over session id in logging #4410
Conversation
config/initializers/99_memleak.rb
Outdated
| #ObjectSpace.dump_all(output: io); | ||
| #io.close | ||
| puts "============= cleaning…" | ||
| GC.start(full_mark: true, immediate_sweep: true); |
There was a problem hiding this comment.
Do not use semicolons to terminate expressions.
config/initializers/99_memleak.rb
Outdated
| trap('USR1') do | ||
| ## beware private temps on RHEL 7+ | ||
| #io = File.open("/tmp/foreman-dump.json", "w") | ||
| #ObjectSpace.dump_all(output: io); |
suggested to use session id if available. Although it seemed as a good idea at the beginning, it has several disadvanteges: * it treats UI and API requests differently * it makes it impossible to differentiate requests made from the session at the same time (notifications is one example, but in general, we should not assume the user is performing on request at a time) * the usability of this as correlation id is questionable, especially with asynchronous actions in place
|
Honestly, we should have both. In structured logging you don't have any limitation of what's "too long" because you introduce new field. Both make perfect sense. If I had to pick one (until we implement journald support where we can really send both) I would pick request which is more globally appropriate IMHO. This depends really, I think if you are more into UI troubleshooting you pick session, if into backend (myself included) you pick request. My biggest argument for request would be that session is unusable for backend while it is still quite usable for UI. Therefore IMHO this is RTM, unless folks have a different opinion (e.g. include both). Edited: Lack of coffee. |
suggested to use session id if available. Although it seemed as a good
idea at the beginning, it has several disadvanteges:
it treats UI and API requests differently
it makes it impossible to differentiate requests made from the session
at the same time (notifications is one example, but in general, we
should not assume the user is performing
on request at a time)
the usability of this as correlation id is questionable, especially
with asynchronous actions in place