Fixes #20908 - postpone initialization of Dynflow runtime #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #20908 |
iNecas
force-pushed
the
postpone-dynflow-initialization
branch
from
bffe93e
to
7cdaf5a
Compare
In #18618, the initialization code was moved from foreman-tasks to foreman. There was however one thing done differently, where the initialization of dynflow world was moved directly to the time `Rails.application.dynflow` was called. This is not right, as there are situations where plugins go and call `Rails.application.dynflow.config` before the whole stack is prepared, which leads to database connection being opened too early, which can cause the whole lot of issues (as we've hit currently with Katello). There was also change in the signature of `Dynflow::Rails#initialize` method, that needs to be updated.
iNecas
force-pushed
the
postpone-dynflow-initialization
branch
from
7cdaf5a
to
43043cf
Compare
iNecas
commented
Sep 12, 2017
| @@ -246,12 +246,27 @@ def dynflow | |||
| if defined?(ForemanTasks) | |||
| ForemanTasks.dynflow | |||
| else | |||
| Dynflow::Rails.new(Foreman::Dynflow::Configuration.new) | |||
| ::Dynflow::Rails.new(nil, Foreman::Dynflow::Configuration.new) | |||
There was a problem hiding this comment.
Dynflow::Rails was resolving to Foreman::Dynlfow::Rails which was not existing: the after_initialize block actually discovered this issue as it seems this code-path was not run in tests before.
There was a problem hiding this comment.
Thanks, I had to do something similar in #4717, can confirm it fixes the problem
There was a problem hiding this comment.
Yes, this should fix the issue you were facing there + making it work with later dynflow version as well that came with Dynflow/dynflow@ff129a6#diff-56fbff8c6eb846b55588d78db914924aR10
|
And all the tests are green again :) |
This was referenced Sep 13, 2017
dLobatog
approved these changes
Sep 13, 2017
|
Thanks @iNecas - this should go into 1.16 I suppose? |
|
yes please |
|
Cherry-picked as 7ad59f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18618, the initialization code was moved from foreman-tasks to
foreman. There was however one thing done differently, where the
initialization of dynflow world was moved directly to the time
Rails.application.dynflowwas called. This is not right, as there aresituations where plugins go and call
Rails.application.dynflow.configbefore the whole stack is prepared, which leads to database connection
being opened too early, which can cause the whole lot of issues (as
we've hit currently with Katello).
There was also change in the signature of
Dynflow::Rails#initializemethod, that needs to be updated.