Fixes #21578 - Cmp.PropTypes to Cmp.propTypes #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea why Travis is failing because of mismatched snapshots? The changes shouldn't affect the snapshots and it is not failing locally. |
|
@sharvit this is the same failure @danseethaler is facing on #4944 - did you figure out which npm package shoudld be pinned? |
|
@ohadlevy - check out my comment on @danseethaler pr #4944 |
sharvit
pushed a commit
to sharvit/foreman
that referenced
this pull request
Nov 6, 2017
Based on those pull requests: theforeman#4944 theforeman#4978 Upgrading the enzyme packages and update the snapshots.
waldenraines
approved these changes
Nov 6, 2017
|
@sharvit please rebase |
Chart, ChartBox and StatisticsChartsList are using prop-types in a wrong way. Chart is declaring about prop-types it is never used. http://projects.theforeman.org/issues/21578
sharvit
force-pushed
the
feature/21578-fix-prop-types
branch
from
8ac48fa
to
3412d4e
Compare
|
Rebased and passed all tests. |
mmack
pushed a commit
to mmack/foreman
that referenced
this pull request
Dec 13, 2017
Based on those pull requests: theforeman#4944 theforeman#4978 Upgrading the enzyme packages and update the snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chart, ChartBox and StatisticsChartsList are using prop-types in a wrong
way.
Chart is declaring about prop-types it is never used.
http://projects.theforeman.org/issues/21578