Fixes #21602 - Add scoped_search on host.id for reports #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #21602 |
tbrisker
suggested changes
Nov 8, 2017
app/models/report.rb
Outdated
| @@ -19,6 +19,7 @@ class Report < ApplicationRecord | |||
| def self.inherited(child) | |||
| child.instance_eval do | |||
| scoped_search :relation => :host, :on => :name, :complete_value => true, :rename => :host | |||
| scoped_search :relation => :host, :on => :id, :complete_value => true, :rename => :host_id | |||
There was a problem hiding this comment.
Why not search on the host_id column? it would save a potentially painful join with the host table. Also, please make this only explicit.
xprazak2
force-pushed
the
search-reports
branch
from
2547e97
to
71d3620
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
houndci-bot
reviewed
Nov 9, 2017
app/models/report.rb
Outdated
| @@ -27,6 +27,8 @@ def self.inherited(child) | |||
| scoped_search :relation => :hostgroup, :on => :title, :complete_value => true, :rename => :hostgroup_title | |||
|
|
|||
| scoped_search :on => :reported_at, :complete_value => true, :default_order => :desc, :rename => :reported, :only_explicit => true | |||
| scoped_search :on => :host_id, :complete_value => true, :only_explicit => true | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at block body end.
xprazak2
force-pushed
the
search-reports
branch
from
71d3620
to
e7c03e5
Compare
|
I changed to search on |
tbrisker
suggested changes
Nov 9, 2017
app/models/report.rb
Outdated
| @@ -27,6 +27,7 @@ def self.inherited(child) | |||
| scoped_search :relation => :hostgroup, :on => :title, :complete_value => true, :rename => :hostgroup_title | |||
|
|
|||
| scoped_search :on => :reported_at, :complete_value => true, :default_order => :desc, :rename => :reported, :only_explicit => true | |||
| scoped_search :on => :host_id, :complete_value => true, :only_explicit => true | |||
xprazak2
force-pushed
the
search-reports
branch
from
e7c03e5
to
5a83399
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
I changed it to |
tbrisker
approved these changes
Nov 9, 2017
|
Thanks @xprazak2 |
|
Setting release to 1.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.