Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22089 - remove unused scope #5129

Merged
merged 1 commit into from
Dec 31, 2017
Merged

Fixes #22089 - remove unused scope #5129

merged 1 commit into from
Dec 31, 2017

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Dec 30, 2017

No description provided.

@theforeman-bot
Copy link
Member

Issues: #22089

@mmoll
Copy link
Contributor Author

mmoll commented Dec 30, 2017

This was used in the original commit 2fa9580 but is unused now.

tbrisker
tbrisker approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find anywhere using this scope either in a sample of several large plugins, I think this is good to go. The best code is no code :)

@tbrisker tbrisker merged commit 85ecc9b into theforeman:develop Dec 31, 2017
@mmoll mmoll deleted the without_tax branch February 18, 2018 21:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmoll @theforeman-bot @tbrisker