Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #22208 - pin audited to 4.5 #5166

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Refs #22208 - pin audited to 4.5 #5166

merged 1 commit into from
Jan 13, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Jan 10, 2018

4.6.0 versions causes test failures on models trying to prevent saved
passwords from being saved in the audit log. This is due to hacks we
added to core along with changes in rails 5.1 change tracking.
This should be fixed to work correctly in the code, but pinning for now
to prevent CI breakage.

@theforeman-bot
Copy link
Member

Issues: #22208

@mmoll
Copy link
Contributor Author

mmoll commented Jan 10, 2018

this is for 1.16

@tbrisker
Copy link
Member

same comment as for GH-5165, only with 4.4.1 here

4.6.0 versions causes test failures on models trying to prevent saved
passwords from being saved in the audit log. This is due to hacks we
added to core along with changes in rails 5.1 change tracking.
This should be fixed to work correctly in the code, but pinning for now
to prevent CI breakage.
@mmoll
Copy link
Contributor Author

mmoll commented Jan 11, 2018

done.

@mmoll mmoll merged commit 02833c7 into theforeman:1.16-stable Jan 13, 2018
@mmoll mmoll deleted the 1.16_audited branch April 3, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants