-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #22256 - refactores statement modifier #5170
Conversation
app/models/notification.rb
Outdated
self.actions = UINotifications::URLResolver.new( | ||
subject, | ||
notification_blueprint.actions | ||
).actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected.
Issues: #22256 |
Needs a rebase now |
thanks @ekohl for the reminder, rebased |
Looks like the prprocessor only works if you first change the PR title and then push an updated PR because there is no webhook event sent for updating the PR title. |
[test foreman] looks like some intermittents |
Actually, the code really looks safe and the test failures were inrelated: merging away, thanks @ares |
No description provided.