-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #22205 - restore blueprint actions for notifications #5159
Conversation
Issues: #22205 |
@ares please rebase on latest develop to fix failing minitest issue |
thanks @tbrisker, rebased |
another rebase for the audited pin is needed now... |
Does this also need the 1.17 milestone? |
it's set in redmine, but I assigned the milestone too, I'll rebase soon |
rebased |
subject, | ||
notification_blueprint.actions | ||
).actions if notification_blueprint.actions.any? | ||
).actions if notification_blueprint.actions.any? && self.actions.blank? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a ruby developer, but multi line statements with guards are hard to parse for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not making the problem worse, since this will be cherrypicked I'd probably keep it as it is, I can open separate PR with refactoring if you prefer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5170 addresses it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ares !
Cherry-picked to 1.17-stable as well as d11899e |
self.actions defaults to
{}
, the logic with conditional overiding is correct but the condition is wrong