Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby 1.9 compatibility issue when loading free ip #518

Closed
wants to merge 1 commit into from

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Apr 12, 2013

In Ruby 1.8.7:

{}.to_s # => ""

In Ruby 1.9.3

{}.to_s # => "{}"

This causes the url for smart proxy to be broken.

In Ruby 1.8.7:

  {}.to_s # => ""

In Ruby 1.9.3

  {}.to_s # => "{}"

This causes the url for smart proxy to be broken.
@domcleal
Copy link
Contributor

Thanks, that looks good.

Could you please file an issue for it and write a test? There's a BMC API test file you could start from, so we begin getting coverage of this class.

@iNecas
Copy link
Member Author

iNecas commented Apr 12, 2013

http://projects.theforeman.org/issues/2398

I would prefer somebody from the core team to write test cases for most of the dhcp api, as that would result it better tests than writing it by me, just for this case. It seems completion of tests for smart proxy is already in progress, I would like to avoid this PR to be part of the tests completion, and have this merged ASAP, since it's a bit blocker for Katello Foreman integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants