Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19855 - Disable Style/ConditionalAssignment cop #5438

Merged
merged 1 commit into from
May 22, 2018
Merged

Fixes #19855 - Disable Style/ConditionalAssignment cop #5438

merged 1 commit into from
May 22, 2018

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Apr 11, 2018

No description provided.

@theforeman-bot
Copy link
Member

Issues: #19855

@lzap
Copy link
Member

lzap commented Apr 13, 2018

I hate this cop. -1

@mmoll mmoll changed the title Fixes #19855 - Fix Style/ConditionalAssignment cop Fixes #19855 - Disable Style/ConditionalAssignment cop Apr 21, 2018
@mmoll
Copy link
Contributor Author

mmoll commented Apr 21, 2018

allright, changed this PR to disable that cop

@theforeman theforeman deleted a comment from theforeman-bot Apr 21, 2018
lzap
lzap previously approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@mmoll
Copy link
Contributor Author

mmoll commented Apr 23, 2018

rebased.

@timogoebel timogoebel merged commit a927f6b into theforeman:develop May 22, 2018
@timogoebel
Copy link
Member

Thanks, @mmoll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timogoebel timogoebel timogoebel approved these changes

@lzap lzap lzap left review comments

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmoll @theforeman-bot @lzap @timogoebel