Fixes #23212 - uninitialized constant #5442
Conversation
|
Do not merge! This patch has not been tested yet. Can an existing organization member please verify this patch? |
2 similar comments
|
Do not merge! This patch has not been tested yet. Can an existing organization member please verify this patch? |
|
Do not merge! This patch has not been tested yet. Can an existing organization member please verify this patch? |
|
Issues: #23212 |
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout
.rubocop.yml: Lint/EndAlignment has the wrong namespace - should be Layout .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/MethodName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
|
I see this is against 1.16. Does this also happen in develop? |
|
Seems like a951f9b - that added this check - never ended up in develop, so the issue doesn't exist there. |
|
Ah, this was introduced in the security fix. @orrabin could you have a look? |
|
ok to test |
|
@ananace I invited you to the foreman organization, if you confirm the invitation and make your membership public your next PRs will automatically kick CI runs. |
There was a problem hiding this comment.
@ekohl This was the fix for 1.15-1.17, develop has a new version of fog-ovirt that fixes this.
I tested with an ovirt machine on 1.17 and this still works as expected.
This should be tested with another compute resource since ovirt did not have the error.
|
I just ran into this with 1.16 and KVM, this patches fixes it. I understood it correctly that this patch is for 1.15, 1.16 and 1.17? |
|
Oh right, I completely missed to check if it applied to 1.15 as well - spoiler alert; It applies to 1.15.7+ as well. |
|
merged, tack @ananace! |
|
cherry-picked to the other stable branches as well. |
|
Will this be applied to 1.17 as well? |
|
yes, af4ed00 |
|
Should I be getting the upgrade from the yum repo then? Or isn't it published yet? |
|
It will be part of 1.16.2 and 1.17.1, which are both not out, yet. |
Seems like the same issue also exists in 1.17, so it would probably have to be cherry-picked/pulled to there as well.