Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24003 - remove babel-polyfill from vendor.js #5714

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

tbrisker
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

Issues: #24003

@tbrisker
Copy link
Member Author

When running with production-compiled assets and plugins using webpack (rex and ansible in my case), this fixed the issue of trying to import it multiple times that caused all js to break

Copy link
Member

@dLobatog dLobatog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as this fixes REX. The job invocation page does not load properly without this (if you follow the method to reproduce nightly issues as described here, substitute katello by foreman_remote_execution: https://community.theforeman.org/t/nightlies-assets-are-now-broken/9810/38?u=dlobatog).

Unfortunately I still get Error: Component not found: ReportJsonViewer among BookmarkContainer, DonutChart, StatisticsChartsList, PowerStatus, NotificationContainer, ToastNotifications, StorageContainer, PasswordStrength, BreadcrumbBar, FactChart on the reports page, error coming from foreman_ansible.

@dLobatog
Copy link
Member

Thanks @tbrisker

@dLobatog dLobatog merged commit bff82b8 into theforeman:develop Jun 19, 2018
@ohadlevy
Copy link
Member

ohadlevy commented Jun 19, 2018 via email

@ares
Copy link
Member

ares commented Jun 19, 2018

Setting redmine release to 1.19, if this needs to be cherrypicked, please update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants