fixes #24050 - graphql: add connections with totalCount #5733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #24050 |
This was referenced Jun 23, 2018
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
d9a02cc
to
af3822a
Compare
|
Rebased and applied @dariuszb-iRonin's suggestion. |
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
af3822a
to
8eb23c4
Compare
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
8eb23c4
to
a9ed394
Compare
|
Rebased. |
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
a9ed394
to
5ba58b0
Compare
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
5ba58b0
to
e15d4c4
Compare
|
Works well, but needs a rebase. |
xprazak2
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
e15d4c4
to
97a66a3
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
97a66a3
to
5c74087
Compare
|
Rebased. |
|
@xprazak2: Do you have a chance to take a look at this PR this morning? If we merge any other graphql PRs before this, we'll have to rebase again. |
kamils-iRonin
previously approved these changes
Mar 13, 2019
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
5c74087
to
5cee910
Compare
|
Rebased. |
|
Aaaah, I did not manage to hit the button in time. I'll merge if you rebase, I promise 🙂 |
timogoebel
force-pushed
the
24050-graphql-connection-total-count
branch
from
5cee910
to
104e812
Compare
|
@xprazak2: You'll get another chance. Rebased (well, actually @kamils-iRonin did it). |
xprazak2
approved these changes
Mar 15, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part four of the graphql series.
This adds support for connections (associations) to the models. It adds a basic host type that just has name, id and model attributes.
Other parts:
Part 1 - JWT Auth: #5596
Part 2 - Graphql Scaffolding: #5680
Part 3 - Relay Global ID #5681
Part 4 - Connections with totalCount #5733
Part 5 - Basic mutations for model #5736